Review main Merged

53711[FEATURE] SVG content object support EXT: syntax

Frank Nägler CR +2 V +2 Easy +43 −5 updated 08/16/17, 09:59

Commit message

The SVG Content Object property „src“ now supports EXT:
syntax to reference files from extensions.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Frank Nägler uploaded patch set 1 08/16/17, 09:16

  2. TYPO3com voted on patch set 1 V +1 08/16/17, 09:27 Completed build in 11m 27s on Wed, 16 Aug, 11:27 AM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13749

  3. Jörg Bösche commented on patch set 1 CR +1 V +1 08/16/17, 09:41

    Succesfully verified on master with: -------------- INLINE page.10 = SVG page.10 { renderMode = inline src = EXT:styleguide/Resources/Public/Icons/provider_svg_icon.svg } page.10 = SVG page.10 { renderMode = inline src = typo3conf/ext/styleguide/Resources/Public/Icons/provider_svg_icon.svg } -------------- NORMAL page.10 = SVG page.10 { src = EXT:styleguide/Resources/Public/Icons/provider_svg_icon.svg } page.10 = SVG page.10 { src = typo3conf/ext/styleguide/Resources/Public/Icons/provider_svg_icon.svg }
  4. Andreas Kienast voted on patch set 1 CR +2 V +2 08/16/17, 09:59

  5. Gerrit merged patch set 1 08/16/17, 09:59