Review main Merged

53714[BUGFIX] Use DriverInterface instead AbstractDriver for method signature

Franz Koch CR +2 V +2 Easy +3 −3 updated 08/18/17, 05:55

Commit message

FAL drivers are not obligated to extend the AbstractDriver but only
to implement the DriverInterface. Having custom drivers that are not
based on AbstractDriver (because they are f.e. non hierarchical)
currently causes an Exception because PreviewProcessing expects an
instance of AbstractDriver as method argument.

This patch changes te signature from AbstractDriver to DriverInterface.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Franz Koch uploaded patch set 1 08/16/17, 12:35

  2. TYPO3com voted on patch set 1 V +1 08/16/17, 12:45 Completed build in 10m 10s on Wed, 16 Aug, 02:45 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13755

  3. Frans Saris updated the commit message in patch set 2 08/16/17, 14:09

  4. Frans Saris voted on patch set 2 CR +1 08/16/17, 14:09

  5. TYPO3com voted on patch set 2 V +1 08/16/17, 14:19 Completed build in 09m 46s on Wed, 16 Aug, 04:19 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13757

  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/17/17, 07:53

  7. Wouter Wolters voted on patch set 2 CR +1 08/17/17, 16:41

  8. Susi Moog voted on patch set 2 CR +2 V +2 08/18/17, 05:55

  9. Gerrit merged patch set 2 08/18/17, 05:55

  10. Susi Moog commented on patch set 3 08/18/17, 05:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 05e06b17f783bd41624eebe277abb8338ad51a2d