Review TYPO3_7-6 Merged

53715[BUGFIX] Do not allow users to edit doktypes without permissions

Susi Moog CR +2 V +2 Easy +30 −2 updated 09/20/17, 16:31

Commit message

Disallow backend users to edit pages which doktypes are not allowed
via backend usergroup permissions.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jan Stockfisch +1
  • Verified V +2
    • Susi Moog +2
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Susi Moog commented on patch set 1 08/17/17, 06:33

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V -1 08/17/17, 06:42 Completed build in 08m 30s on Thu, 17 Aug, 08:42 AM Test Summary: 2 of 21218 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1060

  3. Susi Moog uploaded patch set 2 08/17/17, 07:17

  4. TYPO3com voted on patch set 2 V +1 08/17/17, 07:24 Completed build in 06m 30s on Thu, 17 Aug, 09:24 AM Test Summary: 38916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1061

  5. Sascha Egerer commented on patch set 2 CR -1 08/19/17, 19:14

    DatabaseUserPermissionCheck.php:118

    `$result['databaseRow']['doktype']` should be `$GLOBALS['TCA'][$result['tableName']]['ctrl']['type']`
  6. Sascha Egerer commented on patch set 2 CR 0 08/21/17, 09:21

    Just fixed that in a follow up for master
  7. Jan Stockfisch voted on patch set 2 CR +1 V +1 08/23/17, 08:29

  8. Stephan Großberndt commented on patch set 2 09/07/17, 08:10

    ping
  9. Susi Moog commented on patch set 2 CR +2 V +2 09/20/17, 16:31

    straight backport actually.
  10. Gerrit merged patch set 2 09/20/17, 16:31