Review main Merged

53719[BUGFIX] Prevent XSS in PageLayoutController

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 08/18/17, 13:27

Commit message

Correctly use htmlspecialchars for the link.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wolfgang Klinger +1
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Wouter Wolters uploaded patch set 1 08/17/17, 11:33

  2. Wouter Wolters commented on patch set 1 08/17/17, 11:33

    This is reflected(non persitent) XSS, which means, to exploit this, you need to trick others to follow the link. However in this case the link contains a CSRF token, which cannot be known by the attacker. While this is a valid bug, which needs to be fixed, it is not reasonably exploitable. We can therefore fix this within our public bug fixing process
  3. TYPO3com voted on patch set 1 V +1 08/17/17, 11:44 Completed build in 10m 27s on Thu, 17 Aug, 01:44 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13777

  4. Wolfgang Klinger voted on patch set 1 CR +1 08/17/17, 11:56

  5. Andreas Kienast voted on patch set 1 CR +1 08/17/17, 13:33

  6. Frank Nägler voted on patch set 1 CR +1 V +1 08/18/17, 13:19

  7. Andreas Kienast voted on patch set 1 CR +2 V +2 08/18/17, 13:26

  8. Gerrit merged patch set 1 08/18/17, 13:26

  9. Andreas Kienast commented on patch set 2 08/18/17, 13:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ba2c43fa937fd6799ecf64b0d2d57c28641c51e5