Review main Merged

53721[BUGFIX] Correct type of argument passed to BackendUtility::viewOnClick

Tymoteusz Motylewski CR +2 V +2 Easy +5 −5 updated 08/18/17, 06:13

Commit message

Third argument passed to BackendUtility::viewOnClick should be
an array or null.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
  • Verified V +2
    • Susi Moog +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Tymoteusz Motylewski uploaded patch set 1 08/17/17, 12:30

  2. Wouter Wolters commented on patch set 1 CR -1 08/17/17, 12:34

    PageLayoutController.php:709

    this is not the 3rd param of viewOnClick
  3. TYPO3com voted on patch set 1 V +1 08/17/17, 12:41 Completed build in 11m 31s on Thu, 17 Aug, 02:41 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13780

  4. Tymoteusz Motylewski uploaded patch set 2 08/17/17, 15:12

  5. Wouter Wolters voted on patch set 2 CR +1 V +1 08/17/17, 15:23

  6. TYPO3com voted on patch set 2 V +1 08/17/17, 15:24 Completed build in 11m 04s on Thu, 17 Aug, 05:24 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13786

  7. Susi Moog voted on patch set 2 CR +2 V +2 08/18/17, 06:13

  8. Gerrit merged patch set 2 08/18/17, 06:13