Review main Merged

53724[BUGFIX] Throw exception if encryption key is not set

Helmut Hummel CR +2 V +2 Easy +6 −28 updated 08/22/17, 20:00

Commit message

The encryption key is a vital part to ensure security
of TYPO3. Not having it set (by accident) can lead
to severe security issues.

Therefore enforce it to be set and throw an exception
in case it isn't, instead of just reporting a warning.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Helmut Hummel uploaded patch set 1 08/17/17, 16:42

  2. TYPO3com voted on patch set 1 V -1 08/17/17, 16:52 Completed build in 09m 52s on Thu, 17 Aug, 06:52 PM Test Summary: 2077 of 57896 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13788

  3. Mathias Brodala commented on patch set 1 08/18/17, 09:28

    Bootstrap.php:179

    Can this be checked earlier in the bootstrap to avoid pointless initialization? (E.g. after loadConfigurationAndInitialize)
  4. Sascha Egerer voted on patch set 1 CR +1 08/19/17, 19:11

  5. Jan Stockfisch voted on patch set 1 CR +1 V +1 08/21/17, 07:36

  6. Jan Stockfisch voted on patch set 1 CR 0 V 0 08/21/17, 08:32

  7. Christian Kuhn uploaded patch set 2 08/22/17, 15:25

  8. Christian Kuhn commented on patch set 1 08/22/17, 15:26

    Bootstrap.php:179 Reply

    I don't think that's a problem in this case.
  9. Christian Kuhn commented on patch set 2 08/22/17, 15:26

    test-run to see if that runs through with updated testing-framework package.
  10. TYPO3com voted on patch set 2 V +1 08/22/17, 15:39 Completed build in 14m 07s on Tue, 22 Aug, 05:39 PM Test Summary: 57779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13920

  11. Christian Kuhn uploaded patch set 3 08/22/17, 17:04

  12. Christian Kuhn updated the commit message in patch set 4 08/22/17, 17:05

  13. Christian Kuhn uploaded patch set 5 08/22/17, 17:06

  14. Christian Kuhn voted on patch set 5 CR +1 V +1 08/22/17, 17:09

  15. TYPO3com voted on patch set 3 V -1 08/22/17, 17:24 Completed build in 19m 47s on Tue, 22 Aug, 07:24 PM Test Summary: 1 of 58142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13930

  16. TYPO3com voted on patch set 4 V +1 08/22/17, 17:26 Completed build in 20m 58s on Tue, 22 Aug, 07:26 PM Test Summary: 57779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13931

  17. TYPO3com voted on patch set 5 V +1 08/22/17, 17:31 Completed build in 25m 26s on Tue, 22 Aug, 07:31 PM Test Summary: 57779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13932

  18. Benni Mack voted on patch set 5 CR +2 V +2 08/22/17, 19:31

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 08/22/17, 19:53

  20. Gerrit merged patch set 5 08/22/17, 19:53

  21. Helmut Hummel commented on patch set 6 08/22/17, 20:00

    thanks for the testing framework fix and the quick reviews!