Review TYPO3_8-7 Merged

53725[BUGFIX] Use DriverInterface instead AbstractDriver for method signature

Susi Moog CR +2 V +2 Easy +3 −3 updated 08/18/17, 07:13

Commit message

FAL drivers are not obligated to extend the AbstractDriver but only
to implement the DriverInterface. Having custom drivers that are not
based on AbstractDriver (because they are f.e. non hierarchical)
currently causes an Exception because PreviewProcessing expects an
instance of AbstractDriver as method argument.

This patch changes te signature from AbstractDriver to DriverInterface.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Susi Moog commented on patch set 1 08/18/17, 05:55

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/18/17, 06:07 Completed build in 11m 54s on Fri, 18 Aug, 08:07 AM Test Summary: 58491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-706

  3. Susi Moog voted on patch set 1 CR +2 V +2 08/18/17, 07:13

  4. Gerrit merged patch set 1 08/18/17, 07:13