Review main Merged

53748[FEATURE] Improve status output of refindex update

Sebastian Fischer CR +2 V +2 Hard +340 −60 updated 02/13/20, 10:23

Commit message

With adding progressbar support while updating the reference index,
it is now possible to see which table is updated and how much progress
has already been achieved.

To be able to implement the progressbar in the frontend in a different
way, a progress listener interface is introduced which can be added separately.

At the same time, the FlashMessage logic is now put in the TYPO3 Backend
controller and the $cli_echo is now used to inject the progress listener interface

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Sebastian Fischer +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 4569

Show 2944 earlier messages
  1. Sebastian Fischer uploaded patch set 1 08/20/17, 16:27

  2. Sebastian Fischer uploaded patch set 2 08/20/17, 16:32

  3. Sebastian Fischer uploaded patch set 3 08/20/17, 16:34

  4. Sebastian Fischer uploaded patch set 4 08/20/17, 16:35

  5. TYPO3com voted on patch set 2 V +1 08/20/17, 16:44 Completed build in 11m 59s on Sun, 20 Aug, 06:44 PM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13845

  6. TYPO3com voted on patch set 3 V +1 08/20/17, 16:47 Completed build in 13m 09s on Sun, 20 Aug, 06:47 PM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13846

  7. TYPO3com voted on patch set 4 V +1 08/20/17, 16:50 Completed build in 15m 40s on Sun, 20 Aug, 06:50 PM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13847

  8. TYPO3com voted on patch set 1 V -1 08/20/17, 16:51 Completed build in 23m 16s on Sun, 20 Aug, 06:51 PM Test Summary: 1 of 57956 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13844

  9. Benni Mack commented on patch set 4 08/21/17, 04:46

    Hey Sebastian, thanks for fixing this. Any chance to move the output out of the ReferenceIndex and instead use callback functions in the places mentioned? This is mainly because the RefIndex is also called in non-CLI contexts and I'd wanted to extract this for a long time myself. Thanks again for your work!
  10. Sebastian Fischer uploaded patch set 5 08/21/17, 15:45

  11. TYPO3com voted on patch set 5 V -1 08/21/17, 15:46 Completed build in 09s on Mon, 21 Aug, 05:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13875

  12. Benni Mack uploaded patch set 6 08/21/17, 19:52

  13. TYPO3com voted on patch set 6 V +1 08/21/17, 20:04 Completed build in 11m 39s on Mon, 21 Aug, 10:04 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13882

  14. Tymoteusz Motylewski commented on patch set 6 09/11/17, 12:57

    is it a WIP still?
  15. Alexander Schnitzler commented on patch set 6 09/12/17, 16:54

    I wonder if we need to introduce a class and an interface just to wrap the output of a ProgressBar object. Seems a bit over engineered to me. Besides that I like the idea of using a progress bar to track the progress.
  16. Mathias Schreiber uploaded patch set 7 02/05/18, 20:22

  17. TYPO3com voted on patch set 7 V +1 02/05/18, 20:31 Completed build in 08m 41s on Mon, 5 Feb, 09:31 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18973

  18. Mathias Schreiber uploaded patch set 8 02/05/18, 20:32

  19. TYPO3com voted on patch set 8 V +1 02/05/18, 20:37 Completed build in 05m 33s on Mon, 5 Feb, 09:37 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18975

  20. Andreas Kienast voted on patch set 8 V +1 CR +1 02/05/18, 21:03

  21. Mathias Schreiber voted on patch set 8 V +1 CR +1 02/05/18, 21:03

  22. Wouter Wolters commented on patch set 8 CR -1 02/05/18, 21:35

    CommandProgressListener.php:49 Unresolved

    void can be used since 7.1. I thought we agreed to no use any new features until the final decision was made about 7.2 as base for 9.

    ReferenceIndex.php:1381 Unresolved

    is_null should not be used, use !== null here instead
  23. Mathias Schreiber uploaded patch set 9 02/05/18, 21:47

  24. Mathias Schreiber uploaded patch set 10 02/05/18, 21:48

  25. TYPO3com voted on patch set 10 V +1 02/05/18, 21:57 Completed build in 08m 51s on Mon, 5 Feb, 10:57 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18987

  26. TYPO3com voted on patch set 9 V +1 02/05/18, 21:58 Completed build in 10m 35s on Mon, 5 Feb, 10:58 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18986

  27. Mathias Schreiber voted on patch set 10 V +1 CR +1 02/05/18, 22:06

  28. Wouter Wolters voted on patch set 10 CR +1 02/05/18, 22:06

  29. Oliver Klee updated the commit message in patch set 11 02/05/18, 22:11

  30. TYPO3com voted on patch set 11 V +1 02/05/18, 22:19 Completed build in 07m 33s on Mon, 5 Feb, 11:19 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18989

  31. Georg Ringer commented on patch set 11 02/06/18, 03:21

    please also provide a RST file for the feature! you can write it here https://forger.typo3.com/utility/rst

    ProgressListenerInterface.php:28

    please add type string and int here as well.

    ReferenceIndexUpdateCommand.php:58

    that line is not needed, autocomplete comes with dynamicReturnTypeMeta plugin
  32. Jörg Bösche commented on patch set 11 02/06/18, 13:15

    I'm on it.

    ProgressListenerInterface.php:28 Reply Unresolved

    Done

    ReferenceIndexUpdateCommand.php:58 Reply Unresolved

    Done
  33. Jörg Bösche uploaded patch set 12 02/06/18, 13:15

  34. TYPO3com voted on patch set 12 V +1 02/06/18, 13:21 Completed build in 05m 58s on Tue, 6 Feb, 02:21 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19013

  35. Sascha Rademacher voted on patch set 12 CR +1 02/06/18, 13:34

  36. Benni Mack updated the commit message in patch set 13 02/10/18, 23:45

  37. TYPO3com voted on patch set 13 V -1 02/10/18, 23:55 Completed build in 09m 07s on Sun, 11 Feb, 12:55 AM Test Summary: 1 of 30661 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19329

  38. TYPO3com voted on patch set 13 V +1 02/11/18, 00:04 Completed build in 27m 08s on Sun, 11 Feb, 01:04 AM Test Summary: 30506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19329

  39. Benni Mack commented on patch set 13 02/11/18, 00:07

    gotta put in some more love here... ideally, we can get rid of the "echo" and return stuff of this method, to do this properly. will put some more thoughts into this.
  40. Benni Mack commented on patch set 13 CR -1 10/30/18, 21:32

    working on that one...
  41. Susi Moog commented on patch set 13 03/01/19, 18:47

    @benni: ping? ;)
  42. Wouter Wolters wrote 06/04/19, 13:16

    Removed reviewer Wouter Wolters.
  43. Benni Mack uploaded patch set 14 01/27/20, 13:29

  44. TYPO3com voted on patch set 14 V -1 01/27/20, 13:39 Completed build in 09m 51s on Mon, 27 Jan, 01:39 PM Test Summary: 70316 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40270

  1. TYPO3com voted on patch set 14 V +1 01/27/20, 13:47 Completed build in 27m 50s on Mon, 27 Jan, 01:47 PM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40270

  2. Benni Mack uploaded patch set 15 01/27/20, 15:09

  3. TYPO3com voted on patch set 15 V +1 01/27/20, 15:19 Completed build in 09m 35s on Mon, 27 Jan, 03:19 PM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40276

  4. Sebastian Fischer voted on patch set 15 CR +1 01/27/20, 15:37

  5. Oliver Hader voted on patch set 15 CR +1 01/27/20, 16:07

  6. Tymoteusz Motylewski commented on patch set 15 01/27/20, 19:43

    Feature-82062-ProgressForReferenceIndexUpdateOnCLI.rst:14

    Do I get it right that ProgressListenerInterface is a public API? Please document its usage here then.
  7. Anja Leichsenring updated the commit message in patch set 16 01/28/20, 08:54

  8. TYPO3com voted on patch set 16 V +1 01/28/20, 09:03 Completed build in 08m 45s on Tue, 28 Jan, 09:03 AM Test Summary: 70600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40289

  9. Benni Mack commented on patch set 16 01/30/20, 13:05

    Feature-82062-ProgressForReferenceIndexUpdateOnCLI.rst:14 Reply

    I'd rather not do this as Public API yet. Once somebody(tm) would add a listener concept for the Backend UX (which would be really cool), I guess we'd need to adapt this interface again, so I'll mark it as internal for the time being. The real change / feature benefit is the output, not the new PHP interface.
  10. Benni Mack commented on patch set 17 01/30/20, 13:07

    Published edit on patch set 16.
  11. TYPO3com voted on patch set 17 V -1 01/30/20, 13:07 Completed build in 17s on Thu, 30 Jan, 01:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40358

  12. TYPO3com commented on patch set 17 01/30/20, 14:27 Completed build in 1h 20m 39s on Thu, 30 Jan, 02:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40358

  13. TYPO3com commented on patch set 17 01/31/20, 07:54 Completed build in 20h 07m 36s on Fri, 31 Jan, 07:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40358

  14. Benni Mack rebased onto patch set 18 01/31/20, 10:12

  15. TYPO3com voted on patch set 18 V -1 01/31/20, 10:15 Completed build in 22s on Fri, 31 Jan, 10:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40386

  16. Benni Mack uploaded patch set 19 01/31/20, 10:50

  17. TYPO3com voted on patch set 19 V +1 01/31/20, 11:04 Completed build in 13m 40s on Fri, 31 Jan, 11:04 AM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40393

  18. Benjamin Franzke commented on patch set 19 CR -1 01/31/20, 11:11

    ProgressListener is implemented as a prototype (not as DI-capable service) – as it relies on a runtime-only SymfonyStyle instance as constructor arguments (there will be no way to create an instance via symfony DI). That becomes clear as you manually need to call injectProgressListener() on the ReferenceIndex class to put the runtime information into the service. This puts state into services. (As comparison: That's like trying to inject a PSR-7 request, instead of passing it as method argument) We should rather aim for a signature like: ReferenceIndex::update(bool $testOnly, ?ProgressListenerInterface $progressListener): array; The traditional ReferenceIndex::updateIndex could be deprecated and be a wrapper around update() for the time being.
  19. Benni Mack uploaded patch set 20 02/03/20, 09:29

  20. TYPO3com voted on patch set 20 V +1 02/03/20, 09:39 Completed build in 10m 29s on Mon, 3 Feb, 09:39 AM Test Summary: 71247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40501

  21. Sebastian Fischer voted on patch set 20 CR +1 02/03/20, 13:02

  22. Georg Ringer voted on patch set 20 V +1 CR +1 02/04/20, 07:38

  23. Tymoteusz Motylewski commented on patch set 20 02/05/20, 13:03

    Feature-82062-ProgressForReferenceIndexUpdateOnCLI.rst:14 Reply Unresolved

    I mean, it will be good to document how can somebody add similar feature to his own console command.
  24. Anja Leichsenring voted on patch set 20 V +2 CR +2 02/13/20, 10:23

  25. Anja Leichsenring merged patch set 21 02/13/20, 10:23