Review main Merged

53757[BUGFIX] Mark not set Install Tool password as secure

Frans Saris CR +2 V +2 Easy +1 −1 updated 08/22/17, 20:24

Commit message

To completely disable the Install Tool you can just leave the 
`installToolPassword` value empty in your LocalConfiguration. 
Problem here is that not all password hashing methods can handle an 
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install 
password hashing/check when there is no password.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wolfgang Klinger +1
    • Wouter Wolters +1
    • Sebastian Fischer +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Frans Saris uploaded patch set 1 08/21/17, 13:59

  2. Frans Saris updated the commit message in patch set 2 08/21/17, 14:04

  3. TYPO3com voted on patch set 1 V +1 08/21/17, 14:09 Completed build in 10m 12s on Mon, 21 Aug, 04:09 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13869

  4. Frans Saris updated the commit message in patch set 3 08/21/17, 14:11

  5. TYPO3com voted on patch set 2 V -1 08/21/17, 14:17 Completed build in 13m 02s on Mon, 21 Aug, 04:17 PM Test Summary: 1 of 58136 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13870

  6. TYPO3com voted on patch set 3 V +1 08/21/17, 14:23 Completed build in 11m 39s on Mon, 21 Aug, 04:23 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13871

  7. Wouter Wolters updated the commit message in patch set 4 08/21/17, 15:28

  8. Wouter Wolters voted on patch set 4 CR +1 08/21/17, 15:28

  9. TYPO3com voted on patch set 4 V +1 08/21/17, 15:40 Completed build in 12m 09s on Mon, 21 Aug, 05:40 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13874

  10. Wolfgang Klinger voted on patch set 4 CR +1 08/21/17, 18:55

  11. Jörg Bösche voted on patch set 4 CR +1 08/21/17, 21:30

  12. Christian Kuhn commented on patch set 4 V +1 08/22/17, 11:24

    +1 on testing - but shouldn't we better fix the saltedpasswords warning, too?
  13. Frans Saris commented on patch set 4 08/22/17, 11:41

    I didn't dare to touch PhpassSalt as it's an very old port of Drupal and I couldn't determine the wanted behavior in the code when the value is empty.
  14. Sebastian Fischer voted on patch set 4 CR +1 08/22/17, 14:27

  15. Benni Mack voted on patch set 4 CR +2 V +2 08/22/17, 20:24

  16. Gerrit merged patch set 4 08/22/17, 20:24

  17. Benni Mack commented on patch set 5 08/22/17, 20:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b825d89c2220d2af626cec622bac8b2c46ae5c5d