53759[BUGFIX] Set a leading / for path search in setAbsRefPrefix
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 3555
Show 2130 earlier messages
-
Wolfgang Klinger uploaded patch set 1 08/21/17, 18:17
-
Wolfgang Klinger updated the commit message in patch set 2 08/21/17, 18:19
-
Wolfgang Klinger updated the commit message in patch set 3 08/21/17, 18:20
-
TYPO3com voted on patch set 1 V +1 08/21/17, 18:29 Completed build in 11m 25s on Mon, 21 Aug, 08:29 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13876
-
TYPO3com voted on patch set 2 V +1 08/21/17, 18:33 Completed build in 13m 23s on Mon, 21 Aug, 08:33 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13877
-
Benni Mack commented on patch set 3 08/21/17, 18:36
this will result in issues when having absRefPrefix set to "/" or to "/preview/" - right? -
TYPO3com voted on patch set 3 V +1 08/21/17, 18:36 Completed build in 16m 51s on Mon, 21 Aug, 08:36 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13878
-
Wolfgang Klinger uploaded patch set 4 08/21/17, 18:39
-
Wolfgang Klinger commented on patch set 3 08/21/17, 18:42
No, with absRefPrefix set to / the result will be e.g. /fileadmin/some_file.txt (in that case as before) -
TYPO3com voted on patch set 4 V +1 08/21/17, 18:51 Completed build in 11m 50s on Mon, 21 Aug, 08:51 PM Test Summary: 57773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13879
-
David Gurk commented on patch set 3 08/22/17, 06:37
This work for includeCSS and includeJS (and simliar). Navigation-Links still working. But resources added with f:uri.resource() aren't effected anymore. Their URLs are still "typo3conf/ext/project/Resources/Public/...". Maybe we should append the search with / and not replace the search without. -
David Gurk commented on patch set 4 08/22/17, 07:27
An addition to "But resources added with f:uri.resource() aren't effected anymore." This is true for this view helper used without absolute-attribute set. In this case the setAbsRefPrefix function add the absRefPrefix. Otherwise is the absolute-attribute is set to true, than $renderingContext->getControllerContext()->getRequest()->getBaseUri() is set as URL prefix which uses GeneralUtility::getIndpEnv('TYPO3_SITE_URL'). -
Wolfgang Klinger uploaded patch set 5 08/22/17, 10:09
-
Wolfgang Klinger updated the commit message in patch set 6 08/22/17, 10:13
-
TYPO3com voted on patch set 5 V -1 08/22/17, 10:23 Completed build in 13m 54s on Tue, 22 Aug, 12:23 PM Test Summary: 1 of 58136 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13899
-
TYPO3com voted on patch set 6 V -1 08/22/17, 10:26 Completed build in 13m 07s on Tue, 22 Aug, 12:26 PM Test Summary: 1 of 58136 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13900
-
David Gurk commented on patch set 6 CR +1 08/22/17, 12:21
Patch 6 worked with f:uri.resources too. But only for usage within HTML attributes with double quotes. This might considered as a another bug, since setAbsRefPrefix handles only double quotes. -
Wolfgang Klinger uploaded patch set 7 08/22/17, 13:33
-
Wolfgang Klinger uploaded patch set 8 10/25/17, 13:44
-
TYPO3com voted on patch set 8 V +1 10/25/17, 13:53 Completed build in 08m 42s on Wed, 25 Oct, 03:53 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15871
-
David Gurk commented on patch set 8 CR +1 10/26/17, 09:24
Works as expected. -
Tymoteusz Motylewski commented on patch set 8 10/26/17, 12:58
will this break installations where they worked around the issue (by e.g. adding the slash manually?) -
Georg Ringer commented on patch set 8 10/26/17, 13:46
yes this will break existing websites. I would only add that to master and add a RST file for it -
Wolfgang Klinger uploaded patch set 9 11/08/17, 12:47
-
TYPO3com voted on patch set 9 V +1 11/08/17, 12:56 Completed build in 08m 53s on Wed, 8 Nov, 01:56 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16185
-
Stefan Neufeind commented on patch set 9 11/08/17, 15:34
Is there a test, which could have caught covered this area and now be adjusted to the new behaviour? -
Wolfgang Klinger commented on patch set 9 11/08/17, 16:00
I don't think so, otherwise the bug would not have been introduced ;-) -
Reiner Teubner uploaded patch set 10 02/07/18, 08:54
-
TYPO3com voted on patch set 10 V -1 02/07/18, 08:54 Completed build in 10s on Wed, 7 Feb, 09:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19062
-
Reiner Teubner uploaded patch set 11 02/07/18, 08:56
-
Reiner Teubner commented on patch set 11 02/07/18, 08:57
rebase merge conflict -
TYPO3com voted on patch set 11 V -1 02/07/18, 09:02 Completed build in 05m 52s on Wed, 7 Feb, 10:02 AM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19063
-
Reiner Teubner updated the commit message in patch set 12 02/07/18, 09:59
-
TYPO3com voted on patch set 12 V -1 02/07/18, 10:05 Completed build in 06m 07s on Wed, 7 Feb, 11:05 AM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19065
-
TYPO3com commented on patch set 12 02/07/18, 10:16 Completed build in 22m 35s on Wed, 7 Feb, 11:16 AM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19065
-
TYPO3com commented on patch set 12 02/07/18, 15:50 Completed build in 6h 13m 18s on Wed, 7 Feb, 04:50 PM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19065
-
Mathias Schreiber updated the commit message in patch set 13 02/07/18, 15:51
-
TYPO3com voted on patch set 13 V -1 02/07/18, 15:57 Completed build in 05m 35s on Wed, 7 Feb, 04:57 PM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19078
-
Mathias Schreiber uploaded patch set 14 02/07/18, 16:21
-
Mathias Schreiber uploaded patch set 15 02/07/18, 16:22
-
Mathias Schreiber uploaded patch set 16 02/07/18, 16:30
-
TYPO3com voted on patch set 14 V +1 02/07/18, 16:31 Completed build in 09m 21s on Wed, 7 Feb, 05:31 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19079
-
TYPO3com voted on patch set 15 V +1 02/07/18, 16:31 Completed build in 08m 58s on Wed, 7 Feb, 05:31 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19080
-
TYPO3com voted on patch set 16 V -1 02/07/18, 16:37 Completed build in 06m 46s on Wed, 7 Feb, 05:37 PM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19081
-
Andreas Kienast uploaded patch set 17 02/07/18, 18:15
-
Andreas Kienast commented on patch set 17 02/07/18, 18:15
> Uploaded patch set 17. I have no idea what I'm doing and hope for the best -
TYPO3com voted on patch set 17 V -1 02/07/18, 18:23 Completed build in 08m 34s on Wed, 7 Feb, 07:23 PM Test Summary: 1 of 30613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19083
-
Andreas Kienast uploaded patch set 18 02/07/18, 19:10
-
Andreas Kienast uploaded patch set 19 02/07/18, 19:13
-
Oliver Klee commented on patch set 18 02/07/18, 19:14
Can we please have tests for this? -
TYPO3com voted on patch set 18 V +1 02/07/18, 19:17 Completed build in 07m 05s on Wed, 7 Feb, 08:17 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19089
-
TYPO3com voted on patch set 19 V +1 02/07/18, 19:23 Completed build in 09m 54s on Wed, 7 Feb, 08:23 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19090
-
Andreas Kienast commented on patch set 19 CR -1 02/07/18, 20:04
Will provide tests -
Andreas Kienast commented on patch set 19 V -1 02/08/18, 07:13
My changed don't solve the issue completely. After thinking about it, I'm not sure if setAbsRefPrefix() has any meaningful purpose. I simply disabled this method by early returning and everything will works finde (tested with absRefPrefix = auto / path / domain). -
Wolfgang Klinger abandoned the change 08/29/18, 07:19