Review main Merged

53767[BUGFIX] Do not renumber unique keys in ArrayUtility

Susi Moog CR +2 V +2 Easy +5 −1 updated 08/22/17, 11:08

Commit message

In various places throughout the core we are using timestamps followed
by a dot as unique identifiers for array keys (for example the avatar
service is registered that way). The ArrayUtility renumbering function
renumbers these keys on writing configuration, meaning that you cannot
overwrite services registered like that via the configuration manager.

ArrayUtility should not re-order strings containing a number ending with
a single dot.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Susi Moog uploaded patch set 1 08/22/17, 10:15

  2. Mathias Brodala commented on patch set 1 CR -1 08/22/17, 10:17

    ArrayUtilityTest.php:1520

    Shouldn't this be more like the "returns correctly even though keys are strings but still numeric" dataset, thus out of order originally? ATM it is not verified that there is no reordering.
  3. Susi Moog commented on patch set 1 08/22/17, 10:25

    ArrayUtilityTest.php:1520 Reply

    reordering would mean the strings are integers afterwards, but feel free to change the data set name to something more sensible ;) I'll struggled here, too, cause I wanted to use something more descriptive than "correctly".
  4. Mathias Brodala commented on patch set 1 08/22/17, 10:29

    ArrayUtilityTest.php:1520 Reply

    I'll have a look.
  5. TYPO3com voted on patch set 1 V -1 08/22/17, 10:29 Completed build in 13m 38s on Tue, 22 Aug, 12:29 PM Test Summary: 3 of 58142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13901

  6. Mathias Brodala uploaded patch set 2 08/22/17, 10:42

  7. Mathias Brodala commented on patch set 2 08/22/17, 10:43

    Restored compat with PHP 7.0, made test more obvious.
  8. TYPO3com voted on patch set 2 V +1 08/22/17, 10:54 Completed build in 12m 05s on Tue, 22 Aug, 12:54 PM Test Summary: 57779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13904

  9. Mathias Brodala voted on patch set 2 CR +1 V +1 08/22/17, 11:02

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 08/22/17, 11:07

  11. Gerrit merged patch set 2 08/22/17, 11:08