Review TYPO3_8-7 Merged

53786[BUGFIX] Mark not set Install Tool password as secure

Benni Mack CR +2 V +2 Easy +29 −11 updated 08/23/17, 07:07

Commit message

To completely disable the Install Tool you can just leave the
`installToolPassword` value empty in your LocalConfiguration.
Problem here is that not all password hashing methods can handle an
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install
password hashing/check when there is no password.

Review

  • Code review CR +2
    • Frans Saris +2
  • Verified V +2
    • Frans Saris +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 47

  1. Benni Mack commented on patch set 1 08/22/17, 20:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/22/17, 20:25 Completed build in 10s on Tue, 22 Aug, 10:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-748

  3. Andreas Kienast uploaded patch set 2 08/23/17, 06:02

  4. TYPO3com voted on patch set 2 V -1 08/23/17, 06:13 Completed build in 11m 33s on Wed, 23 Aug, 08:13 AM Test Summary: 1 of 59035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-749

  5. TYPO3com voted on patch set 2 V +1 08/23/17, 06:15 Completed build in 24m 43s on Wed, 23 Aug, 08:15 AM Test Summary: 58671 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-749

  6. Frans Saris voted on patch set 2 CR +2 V +2 08/23/17, 07:07

  7. Gerrit merged patch set 2 08/23/17, 07:07