53789[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile
Commit message
Review
-
Code review CR +2
- Alexander Opitz +2
- Markus Klein +1
- Frank Nägler +1
- Frans Saris +1
- Xavier Perseguers +1
-
Verified V +2
- Alexander Opitz +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2126
Show 1 earlier messages
-
Xavier Perseguers uploaded patch set 1 08/23/17, 11:07
-
TYPO3com voted on patch set 1 V -1 08/23/17, 11:07 Completed build in 09s on Wed, 23 Aug, 01:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13963
-
Xavier Perseguers commented on patch set 1 V -1 08/23/17, 11:50
I can reproduce the problem within a subdir. As long as "config.absRefPrefix" is not configured, the dumpFile link properly and automatically includes the "/subdir/" prefix. But if config.absRefPrefix is configured: ``` config.absRefPrefix = /subdir/ # Default PAGE object: page = PAGE page.10 < styles.content.get ``` then the "subdir/" segment is included twice in generated link. -
Xavier Perseguers uploaded patch set 2 08/23/17, 13:19
-
TYPO3com voted on patch set 2 V -1 08/23/17, 13:19 Completed build in 08s on Wed, 23 Aug, 03:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13966
-
Xavier Perseguers commented on patch set 2 08/23/17, 13:27
FYI, everything roots back to method \TYPO3\CMS\Core\Resource\ResourceStorage::getPublicUrl() which actually generates a "public" URL, and not something "semi-public but still relative to TYPO3 install". So this method will already include the subdirectory name if there is one. As such, it must not be added twice. -
Markus Klein commented on patch set 2 08/23/17, 18:23
Thanks Xavier for taking care!! A note on the releases line: We did not backport the original patch yet, so I suggest targeting this one to master only and doing a proper backport of the original patch which includes these fixes here. -
Xavier Perseguers updated the commit message in patch set 3 08/24/17, 07:11
-
TYPO3com voted on patch set 3 V +1 08/24/17, 07:24 Completed build in 12m 06s on Thu, 24 Aug, 09:24 AM Test Summary: 57730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13986
-
Jörg Bösche voted on patch set 3 CR +1 08/28/17, 09:18
-
Helmut Hummel commented on patch set 3 CR -1 08/31/17, 21:21
ResourceStorage.php:1302instead of adding an if here, we can use PATH_site . 'index.php', which in any case return the correct result, BE or FEResourceStorage.php:1307As I tried to point out here https://review.typo3.org/#/c/53140/8/typo3/sysext/core/Classes/Resource/ResourceStorage.php@1297 already, we must create an URL which includes the host here, if we want resulting URLs to properly work with code like: https://github.com/TYPO3/TYPO3.CMS/blob/f92aee2e944f9465b8b22db547a8967865c578b6/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L1214-L1216 or https://github.com/TYPO3/TYPO3.CMS/blob/f92aee2e944f9465b8b22db547a8967865c578b6/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L3683-L3685ImageService.php:93this...ImageService.php:99... and this can be removed, if we provide scheme and host for the uri as needed anyway -
Helmut Hummel uploaded patch set 4 08/31/17, 21:27
-
Helmut Hummel commented on patch set 4 08/31/17, 21:30
here is my suggestion, which fixes all known (to me) issues and prevents regressions that have been pointed out -
TYPO3com voted on patch set 4 V -1 08/31/17, 21:43 Completed build in 15m 57s on Thu, 31 Aug, 11:43 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14165
-
Helmut Hummel commented on patch set 4 08/31/17, 21:45
-1 by unrelated acceptance test failure -
Markus Klein voted on patch set 4 CR +1 08/31/17, 23:02
-
TYPO3com voted on patch set 4 V +1 09/01/17, 07:41 Completed build in 10h 29m 37s on Fri, 1 Sep, 09:41 AM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14165
-
Markus Klein commented on patch set 4 V +1 10/26/17, 23:18
Seems to work for me on my test systems/cases -
Frans Saris commented on patch set 4 10/27/17, 09:13
so now it always generates an absolute url? -
Helmut Hummel commented on patch set 4 10/27/17, 09:17
@Frans I have no other idea here since the URL can be used in various places, which potentially add absRefPrefix unless it is an absolute url what problems do you see except it being a bit more verbose? -
Markus Klein commented on patch set 4 10/27/17, 09:19
yes -
Frank Nägler voted on patch set 4 CR +1 10/27/17, 12:11
-
Frans Saris commented on patch set 4 CR +1 10/29/17, 12:02
If you depending on the fact that there are no absolute URLs because you re-use the html output somewhere else in different domain context etc this could be an issue. But that is not a use-case we have to tackle. Only place I could think of further is when rendering images in backend/cli context when creating a email for instance. There this could lead to issues where someone now has to adjust his current workaround to get that properly working. But also that shouldn't block this change imo -
Xavier Perseguers voted on patch set 4 CR +1 10/30/17, 13:06
-
Alexander Opitz voted on patch set 4 CR +2 V +2 11/01/17, 09:26
-
Gerrit merged patch set 4 11/01/17, 09:26