Review main Merged

53790[BUGFIX] Always show input field for empty link fields

Johannes Schlier CR +2 V +2 Easy +4 −6 updated 08/29/17, 15:26

Commit message

The trigger values can be hardcoded here, as the previous
filtering only gives us fields for which we want to hide
the explanation and show the input field.
Previuosly each time a new link field was created  (as an
IRRE element for example) the input and explanation fields
were triggered. This created confusion with editors and
also broke the trigger button, so that fields that were in
the explanation mode could not be triggered back to input mode.

Review

  • Code review CR +2
    • Benni Mack +2
    • Sascha Rademacher +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Henning Liebe +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Johannes Schlier uploaded patch set 1 08/23/17, 14:41

  2. Wouter Wolters voted on patch set 1 CR +1 08/23/17, 14:44

  3. TYPO3com voted on patch set 1 V +1 08/23/17, 14:58 Completed build in 16m 09s on Wed, 23 Aug, 04:58 PM Test Summary: 57718 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13967

  4. Henning Liebe voted on patch set 1 CR +1 08/28/17, 08:09

  5. Sascha Rademacher voted on patch set 1 CR +1 08/28/17, 08:12

  6. Anja Leichsenring voted on patch set 1 CR +1 V +1 08/29/17, 15:25

  7. Benni Mack voted on patch set 1 CR +2 V +2 08/29/17, 15:26

  8. Gerrit merged patch set 1 08/29/17, 15:26

  9. Benni Mack commented on patch set 2 08/29/17, 15:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2a1228e7f0cd8b4e0dedfada0b79c884740a3b03