Review main Merged

53800[TASK] Install Tool: Split up Checks into RequestHandlers

Benni Mack CR +2 V +2 Expert +709 −400 updated 08/30/17, 10:05

Commit message

In order to get the controllers free of security checks, the logic of
authentication/session handling is moved from various controllers into
the RequestHandler and the Application.

Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced
which acts as a fallback if TYPO3 is not installed yet, or the installation is
broken (e.g. missing PackageStates.php).

This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler
(which can handle any request) dealing with the StepController, and the
regular RequestHandler (with higher priority) for handling the maintenance
functionality for running installations.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2547

Show 1122 earlier messages
  1. Benni Mack uploaded patch set 1 08/24/17, 19:20

  2. TYPO3com voted on patch set 1 V -1 08/24/17, 19:20 Completed build in 08s on Thu, 24 Aug, 09:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13998

  3. Benni Mack uploaded patch set 2 08/24/17, 20:15

  4. TYPO3com voted on patch set 2 V -1 08/24/17, 20:15 Completed build in 08s on Thu, 24 Aug, 10:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14003

  5. Benni Mack uploaded patch set 3 08/24/17, 20:16

  6. TYPO3com voted on patch set 3 V -1 08/24/17, 20:16 Completed build in 08s on Thu, 24 Aug, 10:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14004

  7. Benni Mack uploaded patch set 4 08/24/17, 21:04

  8. TYPO3com voted on patch set 4 V -1 08/24/17, 21:04 Completed build in 10s on Thu, 24 Aug, 11:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14005

  9. Benni Mack uploaded patch set 5 08/24/17, 21:38

  10. TYPO3com voted on patch set 5 V -1 08/24/17, 21:38 Completed build in 09s on Thu, 24 Aug, 11:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14006

  11. Benni Mack uploaded patch set 6 08/24/17, 21:49

  12. TYPO3com voted on patch set 6 V -1 08/24/17, 21:49 Completed build in 15s on Thu, 24 Aug, 11:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14008

  13. Benni Mack uploaded patch set 7 08/24/17, 21:49

  14. TYPO3com voted on patch set 7 V -1 08/24/17, 22:38 Completed build in 49m 03s on Fri, 25 Aug, 12:38 AM Test Summary: 120 of 58364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14009

  15. Benni Mack uploaded patch set 8 08/25/17, 08:59

  16. TYPO3com voted on patch set 8 V -1 08/25/17, 09:48 Completed build in 48m 57s on Fri, 25 Aug, 11:48 AM Test Summary: 119 of 58364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14018

  17. Benni Mack uploaded patch set 9 08/25/17, 10:24

  18. TYPO3com voted on patch set 9 V -1 08/25/17, 10:24 Completed build in 08s on Fri, 25 Aug, 12:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14019

  19. Benni Mack uploaded patch set 10 08/25/17, 10:26

  20. Benni Mack uploaded patch set 11 08/25/17, 10:38

  21. TYPO3com voted on patch set 10 V -1 08/25/17, 10:41 Completed build in 14m 52s on Fri, 25 Aug, 12:41 PM Test Summary: 4 of 58364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14020

  22. TYPO3com voted on patch set 11 V -1 08/25/17, 11:19 Completed build in 41m 00s on Fri, 25 Aug, 01:19 PM Test Summary: 194 of 58364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14021

  1. Benni Mack uploaded patch set 12 08/29/17, 15:51

  2. TYPO3com voted on patch set 12 V -1 08/29/17, 16:05 Completed build in 13m 58s on Tue, 29 Aug, 06:05 PM Test Summary: 2 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14075

  3. TYPO3com commented on patch set 12 08/29/17, 16:25 Completed build in 48m 02s on Tue, 29 Aug, 06:25 PM Test Summary: 1 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14075

  4. Benni Mack uploaded patch set 13 08/29/17, 17:52

  5. TYPO3com voted on patch set 13 V -1 08/29/17, 17:52 Completed build in 09s on Tue, 29 Aug, 07:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14078

  6. Benni Mack uploaded patch set 14 08/29/17, 17:56

  7. Benni Mack uploaded patch set 15 08/29/17, 18:43

  8. Benni Mack uploaded patch set 16 08/29/17, 18:51

  9. TYPO3com voted on patch set 14 V -1 08/29/17, 18:53 Completed build in 57m 41s on Tue, 29 Aug, 08:53 PM Test Summary: 128 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14079

  10. TYPO3com voted on patch set 15 V -1 08/29/17, 18:59 Completed build in 15m 53s on Tue, 29 Aug, 08:59 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14081

  11. Benni Mack uploaded patch set 17 08/29/17, 19:02

  12. TYPO3com voted on patch set 17 V -1 08/29/17, 19:02 Completed build in 19s on Tue, 29 Aug, 09:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14084

  13. Benni Mack uploaded patch set 18 08/29/17, 19:03

  14. TYPO3com voted on patch set 16 V -1 08/29/17, 19:07 Completed build in 15m 44s on Tue, 29 Aug, 09:07 PM Test Summary: 58083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14082

  15. TYPO3com voted on patch set 18 V -1 08/29/17, 19:21 Completed build in 18m 43s on Tue, 29 Aug, 09:21 PM Test Summary: 12 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14085

  16. TYPO3com voted on patch set 18 V +1 08/29/17, 19:29 Completed build in 45m 27s on Tue, 29 Aug, 09:29 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14085

  17. Benni Mack updated the commit message in patch set 19 08/29/17, 19:43

  18. Wouter Wolters commented on patch set 19 08/29/17, 20:35

    AbstractController.php:37

    type missing

    AbstractController.php:80

    @throws missing

    RequestHandler.php:222

    @throws AuthenticationRequiredException
  19. Benni Mack uploaded patch set 20 08/29/17, 20:40

  20. TYPO3com voted on patch set 20 V -1 08/29/17, 20:59 Completed build in 19m 29s on Tue, 29 Aug, 10:59 PM Test Summary: 1 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14089

  21. TYPO3com voted on patch set 20 V +1 08/29/17, 21:01 Completed build in 40m 36s on Tue, 29 Aug, 11:01 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14089

  22. Wouter Wolters voted on patch set 20 CR +1 08/29/17, 21:08

  23. Susi Moog commented on patch set 20 CR +1 V +1 08/30/17, 07:22

    Tested, OK: Scenario - ENABLE_INSTALL_TOOL file exists - No PackageStates, no LocalConfiguration - Call typo3/index.php --> Step installer Scenario - No PackageStates, no LocalConfiguration, no ENABLE_INSTALL_TOOL - Call typo3/index.php --> First install message, after creation --> Step installer Tested, Error: Scenario: - No FIRST_INSTALL, ENABLE_INSTALL_TOOL, PackageStates - Pre-Existing LocalConfiguration - Message to create FIRST_INSTALL --> ok - Reload Scenario: - ENABLE_INSTALL_TOOL file exists - PackageStates deleted / corrupted - Call typo3/index.php Result (both cases): #1380581244: Redirect loop aborted. If this message is shown again after a reload, your setup is so weird that the install tool is unable to handle it. [I'm guessing the Redirect loop with my LocalConfiguration comes from having mssql settings in there - the install tool still can't handle those.]
  24. Christian Kuhn voted on patch set 20 CR +2 V +2 08/30/17, 10:04

  25. Gerrit merged patch set 20 08/30/17, 10:05