53812[FEATURE] Remove need for "settings." prefix in FlexForm variables
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
- typo3/sysext/core/Documentation/Changelog/master/Feature-82214-AutomaticallyAddSettingsPrefixToFlexFormVariablesInExtbase.rstnew+40 −0
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php5+14 −0
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+35 −0
Review log 2632
Show 47 earlier messages
-
Claus Due uploaded patch set 1 08/26/17, 21:04
-
TYPO3com voted on patch set 1 V -1 08/26/17, 21:47 Completed build in 42m 31s on Sat, 26 Aug, 11:47 PM Test Summary: 103 of 58382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14028
-
Claus Due uploaded patch set 2 08/27/17, 13:35
-
TYPO3com voted on patch set 2 V -1 08/27/17, 13:35 Completed build in 08s on Sun, 27 Aug, 03:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14037
-
Claus Due uploaded patch set 3 08/27/17, 13:36
-
TYPO3com voted on patch set 3 V +1 08/27/17, 13:52 Completed build in 15m 49s on Sun, 27 Aug, 03:52 PM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14038
-
Wouter Wolters commented on patch set 3 08/27/17, 20:40
-
Claus Due commented on patch set 3 08/27/17, 21:41
FrontendConfigurationManager.php:187ReplyDone -
Claus Due commented on patch set 4 08/27/17, 21:42
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 08/27/17, 21:58 Completed build in 15m 30s on Sun, 27 Aug, 11:58 PM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14041
-
Christian Kuhn commented on patch set 4 08/28/17, 15:11
FrontendConfigurationManager.php:194that scream for a set of unit tests: verify merging, verify what exactly takes precedence, verify stuff like "setting.foo.bar" vs. "foo.bar" (multiple dots) still works as expected - we had so many issues with dots in flex keys already, maybe we can avoid them this time ;) -
Claus Due commented on patch set 4 08/31/17, 21:54
FrontendConfigurationManager.php:194ReplyUnit tests will be forthcoming - just wanted to get an initial verdict before I spend more time. If the change is okay and desired I'll go ahead with those :) -
Claus Due uploaded patch set 5 09/02/17, 15:04
-
Claus Due uploaded patch set 6 09/02/17, 15:05
-
TYPO3com voted on patch set 6 V -1 09/02/17, 15:20 Completed build in 15m 20s on Sat, 2 Sep, 05:20 PM Test Summary: 1 of 58430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14181
-
TYPO3com voted on patch set 6 V +1 09/02/17, 15:23 Completed build in 33m 44s on Sat, 2 Sep, 05:23 PM Test Summary: 58067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14181
-
Mathias Schreiber voted on patch set 6 V +1 CR +1 02/18/18, 14:17
-
Sascha Rademacher voted on patch set 6 CR +1 02/19/18, 08:35
-
Henning Liebe voted on patch set 6 V +1 CR +1 02/19/18, 09:04
-
Helmut Hummel commented on patch set 6 CR -1 02/19/18, 09:53
FrontendConfigurationManager.php:188yeah, well. what about the other prefixes persistence. and view. that are possible to be set in flexforms? conceptually ignore that they exist? -
Helmut Hummel commented on patch set 6 02/19/18, 09:56
I don't see how this would improve something as long as other prefixed configuration values in flexform may still exist. we still won't be able to use json storage format, we still need our own flexform parser in extbase for these configuration values -
Helmut Hummel commented on patch set 6 02/19/18, 09:58
it also adds an inconsistency. unprefixed configuration keys will be added to settings, but for persistence and view you still need the prefix -
Claus Due commented on patch set 6 02/19/18, 10:35
> I don't see how this would improve something as long as other prefixed configuration values in flexform may still exist. This particular group of settings, "settings.", is the most likely by far to be defined in a flexform. The other settings are more likely to be configured in TS where nested structures is not a problem. This patch doesn't remove the need for the prefix for those other types. Just for the most frequently used one. > we still won't be able to use json storage format, Assume for a moment the "change flexform storage method" feature patch was merged. Nothing would then prevent us from applying the reverse dotted-path-to-nested-properties processing before saving such arrays. That isn't currently part of the other patch but it could be. We'd still need our special Extbase dotted-key handling though, unless we apply the same processing to every storage format which makes that feature patch a breaking change. > it also adds an inconsistency. unprefixed configuration keys will be added to settings, but for persistence and view you still need the prefix Hmm, I don't agree that's an inconsistency - but I view settings separately from persistence and view configuration (as they are in separate scopes and apply in different contexts). They are already handled and for the majority of use cases also configured differently so that's already "inconsistent" if you view those as being the same thing. -
Helmut Hummel wrote 07/23/18, 18:15
Removed reviewer Helmut Hummel with the following votes: * Code-Review-1 by Helmut Hummel <typo3@helhum.io> -
Alexander Schnitzler commented on patch set 6 03/21/19, 19:04
> Patch Set 6: > > it also adds an inconsistency. unprefixed configuration keys will be added to settings, but for persistence and view you still need the prefix As quite a lot of typoscript options are to be removed in 10 (like many view settings and the classes configuration), I don't see any major issues with seeing all typoscript as mere settings. However, I think this change should be postponed until we have a clearer we about what can and will be stripped from the typoscript configuration. Would that be ok for you Claus? -
Alexander Schnitzler wrote 03/21/19, 19:04
Topic issues/82214 removed -
Alexander Schnitzler wrote 03/21/19, 19:04
Topic set to extbase -
Claus Due commented on patch set 6 04/11/19, 08:18
> Patch Set 6: > As quite a lot of typoscript options are to be removed in 10 (like many view settings and the classes configuration), I don't see any major issues with seeing all typoscript as mere settings. However, I think this change should be postponed until we have a clearer we about what can and will be stripped from the typoscript configuration. Would that be ok for you Claus? I don't see an urgent need to get this merged and ultimately it's up to you if it makes coordination easier to wait - but for me personally I think it's completely feasible and would be a good idea to deliver this FEATURE before the !!! breaking changes. This means people can begin getting familiar with the new/shorter strategy in advance. The good thing about the patch is that it is non-breaking and doesn't prevent us from removing the special scopes afterwards. Even so I only give this patch low to medium priority so don't rush on my behalf. -
Wouter Wolters wrote 06/04/19, 13:15
Removed reviewer Wouter Wolters. -
Christian Kuhn wrote 07/16/20, 09:08
Removed reviewer Christian Kuhn. -
Christian Kuhn commented on patch set 6 11/09/21, 21:58
Hey. I'm going to abandon this issue for now: Nothing happened here for quite a while and beside Helmuts comments that have never been answered, the benefit of removing the 'settings' sub array does not seem to be *that* huge in flex forms. This change can always be resurrected and re-discussed when work continues, but it is dropped for the sake of a more clean review system for now. -
Christian Kuhn abandoned the change 11/09/21, 21:58
FrontendConfigurationManager.php:187