Review main Abandoned

53813[FEATURE] Enable changing FlexForm data storage method

Claus Due CR 0 V 0 Hard +573 −45 updated 11/03/21, 15:03

Commit message

This patch does required refactoring and adds new API
to facilitate changing the stored data format of FlexForm
fields. The storage mechanism can be chagned globally
or per individual TCA field.

The API allows now just other formats of serialised values
but given a custom implementation, would be capable of
storing FlexForm data for example in files or other records,
or duplicate (publish) the data to public files.

See attached RST file for further documentation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 18

Review log 3858

Show 1933 earlier messages
  1. Claus Due uploaded patch set 1 08/27/17, 00:30

  2. TYPO3com voted on patch set 1 V -1 08/27/17, 00:31 Completed build in 13s on Sun, 27 Aug, 02:31 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14029

  3. Claus Due uploaded patch set 2 08/27/17, 11:49

  4. Claus Due uploaded patch set 3 08/27/17, 11:52

  5. TYPO3com voted on patch set 2 V -1 08/27/17, 12:03 Completed build in 13m 57s on Sun, 27 Aug, 02:03 PM Test Summary: 1717 of 58308 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14030

  6. TYPO3com voted on patch set 3 V -1 08/27/17, 12:07 Completed build in 15m 20s on Sun, 27 Aug, 02:07 PM Test Summary: 1249 of 58382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14031

  7. Claus Due uploaded patch set 4 08/27/17, 12:18

  8. Claus Due uploaded patch set 5 08/27/17, 12:26

  9. TYPO3com voted on patch set 4 V -1 08/27/17, 12:26 Completed build in 08m 08s on Sun, 27 Aug, 02:26 PM Test Summary: 899 of 57087 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14032

  10. TYPO3com voted on patch set 5 V -1 08/27/17, 12:40 Completed build in 14m 54s on Sun, 27 Aug, 02:40 PM Test Summary: 1244 of 58382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14033

  11. Claus Due uploaded patch set 6 08/27/17, 12:43

  12. TYPO3com voted on patch set 6 V -1 08/27/17, 12:43 Completed build in 14s on Sun, 27 Aug, 02:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14034

  13. Claus Due uploaded patch set 7 08/27/17, 12:45

  14. Claus Due uploaded patch set 8 08/27/17, 12:55

  15. TYPO3com voted on patch set 7 V -1 08/27/17, 12:55 Completed build in 10m 17s on Sun, 27 Aug, 02:55 PM Test Summary: 1620 of 57826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14035

  16. TYPO3com voted on patch set 8 V -1 08/27/17, 13:10 Completed build in 15m 04s on Sun, 27 Aug, 03:10 PM Test Summary: 2 of 58141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14036

  17. TYPO3com voted on patch set 8 V +1 08/27/17, 13:21 Completed build in 40m 41s on Sun, 27 Aug, 03:21 PM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14036

  18. Claus Due commented on patch set 9 08/28/17, 15:09

    Published edit on patch set 8.
  19. Claus Due commented on patch set 9 08/28/17, 15:09

    Fixed commit message, removed Serialize storage engine, added MySQL JSON column hints to RST file.
  20. TYPO3com voted on patch set 9 V +1 08/28/17, 15:26 Completed build in 17m 19s on Mon, 28 Aug, 05:26 PM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14058

  21. Claus Due uploaded patch set 10 11/30/17, 22:27

  22. TYPO3com voted on patch set 10 V -1 11/30/17, 22:27 Completed build in 14s on Thu, 30 Nov, 11:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17143

  23. Claus Due uploaded patch set 11 11/30/17, 22:28

  24. TYPO3com voted on patch set 11 V +1 11/30/17, 22:37 Completed build in 09m 08s on Thu, 30 Nov, 11:37 PM Test Summary: 57048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17144

  25. Georg Ringer commented on patch set 11 12/06/17, 18:19

    Feature-82212-EnableReplacingFlexFormStorageMethods.rst:38

    use :php: and single ticks

    Feature-82212-EnableReplacingFlexFormStorageMethods.rst:55

    new line missing

    Feature-82212-EnableReplacingFlexFormStorageMethods.rst:84

    line missing, also below ..

    Feature-82212-EnableReplacingFlexFormStorageMethods.rst:198

    * before is imo wrong

    Feature-82212-EnableReplacingFlexFormStorageMethods.rst:209

    NotScanned
  26. Mathias Schreiber uploaded patch set 12 02/05/18, 19:11

  27. Mathias Schreiber uploaded patch set 13 02/05/18, 19:14

  28. TYPO3com voted on patch set 12 V +1 02/05/18, 19:24 Completed build in 12m 28s on Mon, 5 Feb, 08:24 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18956

  29. TYPO3com voted on patch set 13 V +1 02/05/18, 19:24 Completed build in 10m 08s on Mon, 5 Feb, 08:24 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18958

  30. Benni Mack commented on patch set 13 02/11/18, 00:15

    what would be interesting to know if we could change the definiton as well (from XML DS to something else).
  31. Claus Due commented on patch set 13 02/11/18, 01:02

    > what would be interesting to know if we could change the definiton as well (from XML DS to something else) This is technically already possible, but use of other formats require a special class. I did not make this same engine switching for the DS since that's already covered - but it certainly wouldn't hurt to be able to store DS as not-XML. There's just one trap there: only formats that can represent attributes as well as "child nodes" can be used, because our DS uses the "type" and other attributes. But I don't think that's sensible to do in this patch as those are two different APIs. PS: Flux gives an option to make a DS via a set of hierarchal PHP classes; this structure can be created based on any source that can be represented as an array. This is the type of API I'd like to see in the code concerning DS, but it has even wider implication such as allowing building TCA the same way (and dynamically...)
  32. Claus Due commented on patch set 13 02/11/18, 01:10

    By the way, when this gets merged, one of the first things I'll be creating is a substitute for serialised formats, storing FlexForm values as relational database records, perhaps even EAV. The next logical research would be about generating dynamic TCA without a FlexForm wrapper (read: dynamic schema extensions).
  33. Helmut Hummel commented on patch set 13 02/19/18, 10:01

    FlexFormTools.php:1025

    what compatibility? this is new API. why add a new API, that behaves weird? only because old API behave that way?
  1. Claus Due commented on patch set 13 02/19/18, 10:21

    FlexFormTools.php:1025 Reply

    Personally I'd be fine with unleashing the exception but that does mean it's no longer a drop-in replacement that won't require refactoring in third party code.
  2. Anja Leichsenring uploaded patch set 14 04/14/18, 15:51

  3. Anja Leichsenring commented on patch set 14 04/14/18, 15:53

    so what is the preferred handling now?
  4. TYPO3com voted on patch set 14 V +1 04/14/18, 16:00 Completed build in 08m 23s on Sat, 14 Apr, 06:00 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22333

  5. Helmut Hummel wrote 07/23/18, 18:15

    Removed reviewer Helmut Hummel.
  6. Benni Mack commented on patch set 14 11/16/18, 09:11

    Thinking about this further, I suggest we actually introduce a new TCA type "json" which is based on the JSON DB field type, and JSON-Schema for showing how a record could look like. I'd rather have FlexForm die in the long run in favor of JSON in general (because the Schema definition of Pseudo-TCA via XML is bad as is)
  7. Claus Due commented on patch set 14 11/16/18, 12:35

    @benni I'm not opposed to the idea of a "json" TCA type, but this would have to be somehow provided with a schema about how you actually render the JSON values as fields - or it wouldn't make much sense to be able to store it (at least not in terms of UX). I'm thinking it may be more sensible with a more generic "structured data" TCA field type which allows you to switch the method by which data is stored. Then provide this new field type with a way to define a "DS" which would work much the same as FlexForms do today. Although this doesn't get rid of the FlexForms concept (sorry, I don't agree that we should) it does mean some very good improvements. Among other things we will be prepared to store FlexForm data sets not as structured data fields but as EAV or other normalised DB structures. The ability to redefine or make dynamic schema which normally would require database schema changes should not be under-estimated. I think we should plan to improve it and modernise it instead of copping out and removing it (in favor or a much less flexible method involving schema changes during runtime). That said, I think we could improve the UX of FlexForm fields quite a lot, among other things by not treating it as part of all posted values but instead catching it separately and piping it through whichever abstraction the "real" TCA field uses (with json being one of those).
  8. Frank Nägler commented on patch set 14 05/31/19, 13:54

    no activity on this patch since months, is anyone still working on it?
  9. Anja Leichsenring wrote 09/09/19, 08:39

    Removed reviewer Anja Leichsenring.
  10. Susi Moog commented on patch set 14 10/26/19, 07:48

    @Claus: Are you still working on this or can we close this for now as we have other priorities?
  11. Claus Due commented on patch set 14 10/26/19, 08:29

    @Susanne I still think this is relevant and should be merged: * I've heard from a number of clients that they desperately want a different storage engine for FlexForm data. * The patch I created is non-breaking and sits "below" the current FlexForm logic, thus it wouldn't conflict in any way with a "json" or "structured" TCA field if and when this gets added. * This patch works and is a solution to a problem now, and IMHO shouldn't be disregarded because we can imagine a better solution (one alwasy can!) I've raised my arguments above and will avoid repeating them. They're all still relevant ;) Not to disregard Benni's input about the desire for a totally different "structured data" field type - this can very easily be seen as just a step in that direction. Say we do this now and people can choose "json" as storage method - that would, in theory, be future compatible with a "json" field type through nothing more than a change of a single TCA parameter.
  12. Claus Due uploaded patch set 15 09/05/20, 12:37

  13. TYPO3com voted on patch set 15 V -1 09/05/20, 12:38 Completed build in 41s on Sat, 5 Sep, 12:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5277

  14. Claus Due uploaded patch set 16 09/05/20, 12:40

  15. TYPO3com voted on patch set 16 V -1 09/05/20, 13:01 Completed build in 20m 56s on Sat, 5 Sep, 01:01 PM Test Summary: 13056 of 73602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5278

  16. Claus Due uploaded patch set 17 09/06/20, 10:45

  17. TYPO3com voted on patch set 17 V -1 09/06/20, 10:56 Completed build in 11m 17s on Sun, 6 Sep, 10:56 AM Test Summary: 1314 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5295

  18. Frank Nägler wrote 09/06/20, 11:05

    Removed reviewer Frank Nägler.
  19. Claus Due uploaded patch set 18 09/06/20, 11:31

  20. TYPO3com voted on patch set 18 V -1 09/06/20, 11:44 Completed build in 12m 35s on Sun, 6 Sep, 11:44 AM Test Summary: 1220 of 73697 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5300

  21. Jonas Eberle uploaded patch set 19 01/10/21, 11:48

  22. TYPO3com voted on patch set 19 V -1 01/10/21, 11:58 Completed build in 09m 19s on Sun, 10 Jan, 11:58 AM Test Summary: 1473 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8795

  23. Jonas Eberle commented on patch set 19 01/10/21, 12:03

    Just rebased in order to get a feeling for it.
  24. Christian Kuhn commented on patch set 19 11/03/21, 15:03

    Hey. I'll abandon this patch for now and hope it's ok to do so at the moment. As always, it can of course be resurrected or rediscussed in case active contribution continues.
  25. Christian Kuhn abandoned the change 11/03/21, 15:03