53830[FEATURE] Only allow access to install tool for system maintainers
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Module/ModuleLoader.php1+4 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php1+32 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-82266-BackendUsersSystemMaintainers.rstnew+34 −0
- typo3/sysext/install/ext_tables.php+4 −4
Review log 1425
-
Benni Mack uploaded patch set 1 08/29/17, 21:09
-
TYPO3com voted on patch set 1 V -1 08/29/17, 21:09 Completed build in 09s on Tue, 29 Aug, 11:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14092
-
Benni Mack uploaded patch set 2 08/29/17, 21:21
-
TYPO3com voted on patch set 2 V -1 08/29/17, 21:21 Completed build in 09s on Tue, 29 Aug, 11:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14093
-
Benni Mack uploaded patch set 3 08/29/17, 21:23
-
TYPO3com voted on patch set 3 V +1 08/29/17, 21:38 Completed build in 15m 16s on Tue, 29 Aug, 11:38 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14094
-
Benni Mack uploaded patch set 4 08/31/17, 19:10
-
Benni Mack commented on patch set 5 08/31/17, 19:13
Published edit on patch set 4. -
TYPO3com voted on patch set 4 V +1 08/31/17, 19:29 Completed build in 19m 36s on Thu, 31 Aug, 09:29 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14148
-
TYPO3com voted on patch set 5 V +1 08/31/17, 19:32 Completed build in 19m 16s on Thu, 31 Aug, 09:32 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14149
-
Christian Kuhn commented on patch set 5 CR -1 08/31/17, 19:38
i'd love to have this setting as array.ModuleLoader.php:265the $this-> in "$this->BE_USER::ROLE_SYSTEMMAINTAINER" is obsolete.BackendUserAuthentication.php:462i'd prefer an array for this setting. -
Benni Mack uploaded patch set 6 08/31/17, 19:47
-
Benni Mack uploaded patch set 7 08/31/17, 19:55
-
TYPO3com voted on patch set 6 V +1 08/31/17, 20:03 Completed build in 15m 52s on Thu, 31 Aug, 10:03 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14153
-
TYPO3com voted on patch set 7 V +1 08/31/17, 20:12 Completed build in 16m 32s on Thu, 31 Aug, 10:12 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14154
-
Benni Mack uploaded patch set 8 08/31/17, 20:17
-
Benni Mack commented on patch set 9 08/31/17, 20:21
Published edit on patch set 8. -
Christian Kuhn uploaded patch set 10 08/31/17, 20:28
-
Christian Kuhn voted on patch set 10 CR +2 V +2 08/31/17, 20:32
-
TYPO3com voted on patch set 8 V -1 08/31/17, 20:35 Completed build in 17m 23s on Thu, 31 Aug, 10:35 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14157
-
TYPO3com voted on patch set 9 V +1 08/31/17, 20:39 Completed build in 17m 22s on Thu, 31 Aug, 10:39 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14158
-
Susi Moog voted on patch set 10 CR +1 V +1 08/31/17, 20:39
-
TYPO3com voted on patch set 10 V -1 08/31/17, 20:45 Completed build in 16m 56s on Thu, 31 Aug, 10:45 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14159
-
TYPO3com voted on patch set 10 V +1 08/31/17, 20:51 Completed build in 39m 49s on Thu, 31 Aug, 10:51 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14159
-
Gerrit merged patch set 10 08/31/17, 20:52