Review main Merged

53830[FEATURE] Only allow access to install tool for system maintainers

Benni Mack CR +2 V +2 Normal +76 −4 updated 08/31/17, 20:52

Commit message

A new option $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers']
is introduced, which contains a list of Backend User uids. It is
then possible to restrict access to backend modules to system
maintainers - most importantly the four Install Tool modules.

When this option is not set in LocalConfiguration.php, then all
admins are system maintainers, same goes for accessing TYPO3
in Development context.

This is the first step to remove the necessary "enter your
intall tool password" when accessing the install tool from
within TYPO3 Backend.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1425

  1. Benni Mack uploaded patch set 1 08/29/17, 21:09

  2. TYPO3com voted on patch set 1 V -1 08/29/17, 21:09 Completed build in 09s on Tue, 29 Aug, 11:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14092

  3. Benni Mack uploaded patch set 2 08/29/17, 21:21

  4. TYPO3com voted on patch set 2 V -1 08/29/17, 21:21 Completed build in 09s on Tue, 29 Aug, 11:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14093

  5. Benni Mack uploaded patch set 3 08/29/17, 21:23

  6. TYPO3com voted on patch set 3 V +1 08/29/17, 21:38 Completed build in 15m 16s on Tue, 29 Aug, 11:38 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14094

  7. Benni Mack uploaded patch set 4 08/31/17, 19:10

  8. Benni Mack commented on patch set 5 08/31/17, 19:13

    Published edit on patch set 4.
  9. TYPO3com voted on patch set 4 V +1 08/31/17, 19:29 Completed build in 19m 36s on Thu, 31 Aug, 09:29 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14148

  10. TYPO3com voted on patch set 5 V +1 08/31/17, 19:32 Completed build in 19m 16s on Thu, 31 Aug, 09:32 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14149

  11. Christian Kuhn commented on patch set 5 CR -1 08/31/17, 19:38

    i'd love to have this setting as array.

    ModuleLoader.php:265

    the $this-> in "$this->BE_USER::ROLE_SYSTEMMAINTAINER" is obsolete.

    BackendUserAuthentication.php:462

    i'd prefer an array for this setting.
  12. Benni Mack uploaded patch set 6 08/31/17, 19:47

  13. Benni Mack uploaded patch set 7 08/31/17, 19:55

  14. TYPO3com voted on patch set 6 V +1 08/31/17, 20:03 Completed build in 15m 52s on Thu, 31 Aug, 10:03 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14153

  15. TYPO3com voted on patch set 7 V +1 08/31/17, 20:12 Completed build in 16m 32s on Thu, 31 Aug, 10:12 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14154

  16. Benni Mack uploaded patch set 8 08/31/17, 20:17

  17. Benni Mack commented on patch set 9 08/31/17, 20:21

    Published edit on patch set 8.
  18. Christian Kuhn uploaded patch set 10 08/31/17, 20:28

  19. Christian Kuhn voted on patch set 10 CR +2 V +2 08/31/17, 20:32

  20. TYPO3com voted on patch set 8 V -1 08/31/17, 20:35 Completed build in 17m 23s on Thu, 31 Aug, 10:35 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14157

  21. TYPO3com voted on patch set 9 V +1 08/31/17, 20:39 Completed build in 17m 22s on Thu, 31 Aug, 10:39 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14158

  22. Susi Moog voted on patch set 10 CR +1 V +1 08/31/17, 20:39

  23. TYPO3com voted on patch set 10 V -1 08/31/17, 20:45 Completed build in 16m 56s on Thu, 31 Aug, 10:45 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14159

  24. TYPO3com voted on patch set 10 V +1 08/31/17, 20:51 Completed build in 39m 49s on Thu, 31 Aug, 10:51 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14159

  25. Gerrit merged patch set 10 08/31/17, 20:52