Review main Merged

53831[TASK] Fluid: Migrate same methods into AbstractTemplateView

Benni Mack CR +2 V +2 Normal +90 −150 updated 09/05/17, 06:27

Commit message

StandaloneView currently replicates a lot of code which is already
present within TemplateView (= Extbase), however, both classes inherit
from AbstractTemplateView.

In order to see which parts are different (and continue on streamlining
fluid) the parts can be placed within AbstractTemplateView.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Benni Mack uploaded patch set 1 08/30/17, 06:10

  2. TYPO3com voted on patch set 1 V +1 08/30/17, 06:27 Completed build in 16m 33s on Wed, 30 Aug, 08:27 AM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14095

  3. Claus Due commented on patch set 1 08/30/17, 10:16

    The end goal with these Views should be to unify TemplateView and StandaloneView with the intention of removing StandaloneView and AbstractTemplateView and begin subclassing Fluid's View class directly. CMS TemplateView then holds every property and is able to render standalone or MVC templates alike.
  4. Benni Mack updated the commit message in patch set 2 08/31/17, 20:08

  5. Benni Mack commented on patch set 2 08/31/17, 20:08

    agreed
  6. TYPO3com voted on patch set 2 V +1 08/31/17, 20:27 Completed build in 19m 34s on Thu, 31 Aug, 10:27 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14156

  7. Oliver Klee commented on patch set 2 08/31/17, 23:15

    This looks more like a [CLEANUP] to me.
  8. Jörg Bösche commented on patch set 2 CR +1 V +1 09/04/17, 06:44

    The code refactoring works. As Oliver mentioned, it might be a [CLEANUP] task.
  9. Benni Mack commented on patch set 2 09/04/17, 12:04

    Reply

    debateable. I don't mind changing it, but it's more or less a "unification of the code", not a classic "code cleanup" where comments are streamlined etc. but looks like we should re-define these prefixes...
  10. Georg Ringer voted on patch set 2 CR +1 V +1 09/05/17, 05:42

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 09/05/17, 06:27

  12. Gerrit merged patch set 2 09/05/17, 06:27