Review main Merged

53832[BUGFIX] Fluid: Strict type checking when adding debug namespace

Benni Mack CR +2 V +2 Easy +5 −6 updated 09/10/17, 14:24

Commit message

The check on BE_USER->uc() in frontend context is cleaned up and more
strict, checking whether the object exists currently.

Additionally, the specific request type is used here.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Benni Mack uploaded patch set 1 08/30/17, 06:13

  2. TYPO3com voted on patch set 1 V -1 08/30/17, 07:02 Completed build in 48m 48s on Wed, 30 Aug, 09:02 AM Test Summary: 116 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14096

  3. TYPO3com commented on patch set 1 08/30/17, 09:29 Completed build in 4h 05m 13s on Wed, 30 Aug, 11:29 AM Test Summary: 10 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14096

  4. TYPO3com voted on patch set 1 V +1 09/07/17, 12:55 Completed build in 10h 47m 38s on Thu, 7 Sep, 02:55 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14096

  5. Tymoteusz Motylewski commented on patch set 1 CR -1 09/07/17, 17:28

    issue number missing
  6. Benni Mack updated the commit message in patch set 2 09/08/17, 23:15

  7. TYPO3com voted on patch set 2 V +1 09/08/17, 23:33 Completed build in 17m 51s on Sat, 9 Sep, 01:33 AM Test Summary: 56809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14609

  8. Stefan Neufeind voted on patch set 2 CR +1 09/09/17, 17:27

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 09/10/17, 14:15

  10. Stefan Neufeind voted on patch set 2 CR +2 V +2 09/10/17, 14:23

  11. Gerrit merged patch set 2 09/10/17, 14:24

  12. Stefan Neufeind commented on patch set 3 09/10/17, 14:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f749adb7d1bff45dad7efb3f4812db45636fc9cd