Review main Merged

53836[TASK] Move signal slots from EXT:install to EXT:core

Benni Mack CR +2 V +2 Easy +12 −16 updated 08/31/17, 14:43

Commit message

The left-over signals in EXT:install/ext_localconf.php belong
to EXT:core (uses classes from EXT:core anyways) and since
both extensions are required at any time (part of minimal system)
this is just a separation cleanup.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 611

  1. Benni Mack uploaded patch set 1 08/30/17, 10:40

  2. TYPO3com voted on patch set 1 V -1 08/30/17, 10:40 Completed build in 08s on Wed, 30 Aug, 12:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14104

  3. Benni Mack uploaded patch set 2 08/31/17, 05:01

  4. TYPO3com voted on patch set 2 V -1 08/31/17, 05:03 Completed build in 02m 17s on Thu, 31 Aug, 07:03 AM Test Summary: 3959 of 58374 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14117

  5. TYPO3com commented on patch set 2 08/31/17, 06:51 Completed build in 1h 52m 03s on Thu, 31 Aug, 08:51 AM Test Summary: 3959 of 58374 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14117

  6. Benni Mack commented on patch set 3 08/31/17, 11:02

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V -1 08/31/17, 11:45 Completed build in 42m 46s on Thu, 31 Aug, 01:45 PM Test Summary: 98 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14121

  8. TYPO3com voted on patch set 3 V +1 08/31/17, 14:37 Completed build in 4h 16m 46s on Thu, 31 Aug, 04:37 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14121

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/31/17, 14:39

  10. Jan Helke voted on patch set 3 CR +1 V +1 08/31/17, 14:41

  11. Gerrit merged patch set 3 08/31/17, 14:43