53837[TASK] Install Tool: Migrate authentication logic into AuthenticationService
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php1new+147 −0
- typo3/sysext/install/Classes/Controller/AbstractController.php+0 −193
- typo3/sysext/install/Classes/Controller/AjaxController.php+2 −7
- typo3/sysext/install/Classes/Controller/StepController.php+58 −38
- typo3/sysext/install/Classes/Controller/ToolController.php+3 −35
- typo3/sysext/install/Classes/Http/RecoveryRequestHandler.php+60 −20
- typo3/sysext/install/Classes/Http/RequestHandler.php+96 −24
Review log 916
-
Benni Mack uploaded patch set 1 08/30/17, 11:24
-
TYPO3com voted on patch set 1 V -1 08/30/17, 11:38 Completed build in 14m 50s on Wed, 30 Aug, 01:38 PM Test Summary: 8 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14108
-
Benni Mack uploaded patch set 2 08/31/17, 15:49
-
Benni Mack uploaded patch set 3 08/31/17, 15:59
-
TYPO3com voted on patch set 2 V -1 08/31/17, 16:08 Completed build in 18m 20s on Thu, 31 Aug, 06:08 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14138
-
TYPO3com voted on patch set 3 V -1 08/31/17, 16:14 Completed build in 15m 29s on Thu, 31 Aug, 06:14 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14140
-
TYPO3com commented on patch set 3 08/31/17, 17:40 Completed build in 1h 57m 01s on Thu, 31 Aug, 07:40 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14140
-
Benni Mack uploaded patch set 4 08/31/17, 17:54
-
TYPO3com voted on patch set 4 V -1 08/31/17, 18:08 Completed build in 14m 35s on Thu, 31 Aug, 08:08 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14142
-
Benni Mack uploaded patch set 5 08/31/17, 18:33
-
TYPO3com voted on patch set 5 V -1 08/31/17, 18:47 Completed build in 13m 45s on Thu, 31 Aug, 08:47 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14144
-
TYPO3com voted on patch set 5 V +1 08/31/17, 18:48 Completed build in 28m 58s on Thu, 31 Aug, 08:48 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14144
-
Christian Kuhn voted on patch set 5 CR +2 V +2 08/31/17, 18:48
-
Susi Moog voted on patch set 5 CR +1 V +1 08/31/17, 18:49
-
Gerrit merged patch set 5 08/31/17, 18:50
-
Mathias Brodala commented on patch set 6 09/04/17, 09:38
AuthenticationService.php:81