Review main Merged

53837[TASK] Install Tool: Migrate authentication logic into AuthenticationService

Benni Mack CR +2 V +2 Hard +366 −317 updated 09/04/17, 09:38

Commit message

The PHP request flow logic for authentication against the install tool password
is moved into a new class called AuthenticationService.

Additionally, all logic which is only needed inside the StepController is moved
from the AbstractController into the StepController or the recovery request handler.

ToolController and AjaxController are now free of session handling completely.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 916

  1. Benni Mack uploaded patch set 1 08/30/17, 11:24

  2. TYPO3com voted on patch set 1 V -1 08/30/17, 11:38 Completed build in 14m 50s on Wed, 30 Aug, 01:38 PM Test Summary: 8 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14108

  3. Benni Mack uploaded patch set 2 08/31/17, 15:49

  4. Benni Mack uploaded patch set 3 08/31/17, 15:59

  5. TYPO3com voted on patch set 2 V -1 08/31/17, 16:08 Completed build in 18m 20s on Thu, 31 Aug, 06:08 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14138

  6. TYPO3com voted on patch set 3 V -1 08/31/17, 16:14 Completed build in 15m 29s on Thu, 31 Aug, 06:14 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14140

  7. TYPO3com commented on patch set 3 08/31/17, 17:40 Completed build in 1h 57m 01s on Thu, 31 Aug, 07:40 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14140

  8. Benni Mack uploaded patch set 4 08/31/17, 17:54

  9. TYPO3com voted on patch set 4 V -1 08/31/17, 18:08 Completed build in 14m 35s on Thu, 31 Aug, 08:08 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14142

  10. Benni Mack uploaded patch set 5 08/31/17, 18:33

  11. TYPO3com voted on patch set 5 V -1 08/31/17, 18:47 Completed build in 13m 45s on Thu, 31 Aug, 08:47 PM Test Summary: 1 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14144

  12. TYPO3com voted on patch set 5 V +1 08/31/17, 18:48 Completed build in 28m 58s on Thu, 31 Aug, 08:48 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14144

  13. Christian Kuhn voted on patch set 5 CR +2 V +2 08/31/17, 18:48

  14. Susi Moog voted on patch set 5 CR +1 V +1 08/31/17, 18:49

  15. Gerrit merged patch set 5 08/31/17, 18:50

  16. Mathias Brodala commented on patch set 6 09/04/17, 09:38

    AuthenticationService.php:81

    It's just through this change that I learned of this option, thanks.