Review TYPO3_7-6 Merged

53842[BUGFIX] Prevent command exit status overflow to non-error status

Christian Kuhn CR +2 V +2 Easy +4 −0 updated 08/31/17, 13:18

Commit message

If a command throws an exception the exception code will be used
as exit code of the CLI command. This will result in an integer overflow
since exit codes are limited to 255, whereas 255 is reserved for PHP.
(See PHP exit documentation)

This commit checks if the return code will result in a 0 and change it to 1 instead.
In TYPO3 v9 the exit code is limited by Symfony Console so no change in master is needed.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 08/31/17, 13:08

    Cherry Picked from branch TYPO3_8-7.
  2. Christian Kuhn voted on patch set 1 CR -1 08/31/17, 13:09

  3. TYPO3com voted on patch set 1 V +1 08/31/17, 13:17 Completed build in 08m 50s on Thu, 31 Aug, 03:17 PM Test Summary: 39152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1088

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 08/31/17, 13:17

  5. Gerrit merged patch set 1 08/31/17, 13:18