Review main Merged

53845[BUGFIX] RSA encryption: Stop submit handling if requested

Andreas Kienast CR +2 V +2 Easy +4 −0 updated 10/06/17, 10:47

Commit message

If the submit event of a form using RSA encryption has `cancelBubble` set
to true (e.g. by jQuery's stopPropagation()), any processing is stopped
to prevent submitting the form.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Andreas Kienast uploaded patch set 1 08/31/17, 13:42

  2. TYPO3com voted on patch set 1 V -1 08/31/17, 14:09 Completed build in 27m 37s on Thu, 31 Aug, 04:09 PM Test Summary: 1 of 58448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14130

  3. TYPO3com voted on patch set 1 V +1 08/31/17, 14:13 Completed build in 58m 47s on Thu, 31 Aug, 04:13 PM Test Summary: 58085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14130

  4. Henrik Elsner voted on patch set 1 CR +1 09/01/17, 06:25

  5. Andreas Kienast commented on patch set 1 CR -1 09/01/17, 07:34

    Checking something...
  6. Andreas Kienast voted on patch set 1 CR 0 09/01/17, 07:45

  7. Markus Klein voted on patch set 1 CR +1 V +1 09/12/17, 14:26

  8. Markus Klein commented on patch set 1 09/12/17, 14:28

    just one question regarding the use case: is this the right thing? validation void usully disable the default with preventDefault(). stopping propagation is usually not what you want to do
  9. Andreas Kienast updated the commit message in patch set 2 10/05/17, 10:11

  10. TYPO3com voted on patch set 2 V +1 10/05/17, 10:20 Completed build in 09m 23s on Thu, 5 Oct, 12:20 PM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15387

  11. Markus Klein voted on patch set 2 CR +1 V +1 10/05/17, 13:08

  12. Christian Kuhn voted on patch set 2 CR +2 V +2 10/06/17, 10:47

  13. Gerrit merged patch set 2 10/06/17, 10:47

  14. Christian Kuhn commented on patch set 3 10/06/17, 10:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c4ed505bc8377fe74313304cfda479477709d123