Review main Merged

53856[TASK] Install Tool: Introduce PSR-7 response objects

Benni Mack CR +2 V +2 Normal +127 −94 updated 08/31/17, 20:53

Commit message

Uses PSR-7 instead of plain echo() and die - and shutdown the
install tool properly (except for redirects currently).

In the future, we should introduce proper PSR-7 response objects
for certain responses (JSON, Redirect) but this will happen in
a separate step.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 714

  1. Benni Mack uploaded patch set 1 08/31/17, 18:34

  2. TYPO3com voted on patch set 1 V -1 08/31/17, 18:34 Completed build in 10s on Thu, 31 Aug, 08:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14145

  3. Benni Mack uploaded patch set 2 08/31/17, 19:01

  4. TYPO3com voted on patch set 2 V -1 08/31/17, 19:20 Completed build in 18m 41s on Thu, 31 Aug, 09:20 PM Test Summary: 4 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14147

  5. TYPO3com commented on patch set 2 08/31/17, 19:30 Completed build in 47m 28s on Thu, 31 Aug, 09:30 PM Test Summary: 4 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14147

  6. Benni Mack uploaded patch set 3 08/31/17, 19:32

  7. TYPO3com voted on patch set 3 V -1 08/31/17, 19:51 Completed build in 19m 23s on Thu, 31 Aug, 09:51 PM Test Summary: 12 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14152

  8. TYPO3com voted on patch set 3 V +1 08/31/17, 19:58 Completed build in 46m 04s on Thu, 31 Aug, 09:58 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14152

  9. Benni Mack updated the commit message in patch set 4 08/31/17, 20:06

  10. TYPO3com voted on patch set 4 V -1 08/31/17, 20:29 Completed build in 23m 16s on Thu, 31 Aug, 10:29 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14155

  11. TYPO3com voted on patch set 4 V +1 08/31/17, 20:33 Completed build in 51m 05s on Thu, 31 Aug, 10:33 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14155

  12. Susi Moog voted on patch set 4 CR +1 V +1 08/31/17, 20:52

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 08/31/17, 20:53

  14. Gerrit merged patch set 4 08/31/17, 20:53