53860[TASK] Install Tool: Remove authentication from backend context
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Romain Canon +1
-
Verified V +2
- Andreas Kienast +2
- Romain Canon +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php+0 −8
- typo3/sysext/core/Tests/Acceptance/Backend/Install/InstallModuleCest.phpdeleted+0 −112
- typo3/sysext/install/Classes/Controller/Action/AbstractAction.php3+12 −13
- typo3/sysext/install/Classes/Controller/Action/ActionInterface.php1+7 −0
- typo3/sysext/install/Classes/Controller/AbstractController.php+1 −7
- typo3/sysext/install/Classes/Controller/AjaxController.php+1 −0
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+68 −56
- typo3/sysext/install/Classes/Controller/StepController.php+5 −0
- typo3/sysext/install/Classes/Controller/ToolController.php+1 −0
- typo3/sysext/install/Classes/Service/ContextService.php1+4 −5
- typo3/sysext/install/ext_tables.php+4 −24
Review log 1426
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 08/31/17, 21:51
-
TYPO3com voted on patch set 1 V -1 08/31/17, 21:52 Completed build in 06s on Thu, 31 Aug, 11:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14166
-
Benni Mack uploaded patch set 2 09/01/17, 07:00
-
TYPO3com voted on patch set 2 V -1 09/01/17, 07:00 Completed build in 06s on Fri, 1 Sep, 09:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14169
-
TYPO3com commented on patch set 2 09/01/17, 12:35 Completed build in 01m 13s on Fri, 1 Sep, 02:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14169
-
Benni Mack uploaded patch set 3 09/01/17, 13:09
-
TYPO3com voted on patch set 3 V -1 09/01/17, 13:24 Completed build in 14m 49s on Fri, 1 Sep, 03:24 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173
-
TYPO3com commented on patch set 3 09/02/17, 18:34 Completed build in 5h 40m 00s on Sat, 2 Sep, 08:34 PM Test Summary: 3 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173
-
TYPO3com commented on patch set 3 09/02/17, 18:37 Completed build in 11h 07m 32s on Sat, 2 Sep, 08:37 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173
-
TYPO3com commented on patch set 3 09/05/17, 13:12 Completed build in 11h 09m 59s on Tue, 5 Sep, 03:12 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173
-
Benni Mack uploaded patch set 4 09/05/17, 14:01
-
TYPO3com voted on patch set 4 V -1 09/05/17, 14:01 Completed build in 10s on Tue, 5 Sep, 04:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14223
-
Benni Mack uploaded patch set 5 09/05/17, 14:01
-
TYPO3com voted on patch set 5 V -1 09/05/17, 14:24 Completed build in 22m 50s on Tue, 5 Sep, 04:24 PM Test Summary: 2 of 58440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14224
-
TYPO3com voted on patch set 5 V +1 09/05/17, 15:57 Completed build in 2h 18m 03s on Tue, 5 Sep, 05:57 PM Test Summary: 58077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14224
-
Mona Muzaffar commented on patch set 5 V +1 09/06/17, 19:05
AbstractAction.php:158small typo 'creataes'. -
Mona Muzaffar commented on patch set 5 09/06/17, 19:13
small typo 'your' instead of 'you' -
Stefan Neufeind commented on patch set 5 V +1 09/07/17, 07:13
verified it's usable through the backend as well as standalone basic review of the code (though I'll not call that "code-review" for the moment) -
Markus Hölzle commented on patch set 5 09/07/17, 08:50
AbstractAction.php:162I would add PHP7 type declaration "string"ActionInterface.php:56I would add PHP7 type declaration "string"ContextService.php:32I would add PHP7 type declaration "string" -
Markus Hölzle voted on patch set 5 V +1 09/07/17, 08:54
-
Romain Canon uploaded patch set 6 09/07/17, 13:34
-
TYPO3com voted on patch set 6 V -1 09/07/17, 13:54 Completed build in 20m 32s on Thu, 7 Sep, 03:54 PM Test Summary: 1 of 58494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14305
-
Romain Canon commented on patch set 6 CR +1 V +1 09/07/17, 14:05
Works fine, some old code/files should probably be removed when this patch is merged. -
TYPO3com voted on patch set 6 V +1 09/07/17, 14:12 Completed build in 58m 51s on Thu, 7 Sep, 04:12 PM Test Summary: 58131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14305
-
Andreas Kienast voted on patch set 6 CR +2 V +2 09/07/17, 14:40
-
Gerrit merged patch set 6 09/07/17, 14:40
AbstractAction.php:154