Review main Merged

53860[TASK] Install Tool: Remove authentication from backend context

Benni Mack CR +2 V +2 Hard +103 −225 updated 09/07/17, 14:40

Commit message

Currently calling the install tool modules from within the Backend does a
simple redirect with adding GET variables.

That's the reason why you need to re-authenticate again, and the context
is handed over as a query parameter, which is simply not needed at all.

Now, the redirect is removed, as the Backend entrypoint / request handler
handles the authentication of the backend user, and the standalone entry
point deals with the install tool password etc.

The context parameter is now detected by the entry point (!) as well,
allowing to get rid of quite some code.

There are some more consequences:
- Calling the install tool from the backend does not validate if you configuration
is set up (= recovery necessary) -> since you're already in the backend we guess
you're fine anyway.
- Redirect functionality is almost not needed anymore in the regular request handler
- routeParameters concept was removed again (which was introduced a couple of weeks ago)

Additionally, the contextService could be replaced at a later stage with just
a string.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Romain Canon +1
  • Verified V +2
    • Andreas Kienast +2
    • Romain Canon +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1426

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 08/31/17, 21:51

  1. TYPO3com voted on patch set 1 V -1 08/31/17, 21:52 Completed build in 06s on Thu, 31 Aug, 11:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14166

  2. Benni Mack uploaded patch set 2 09/01/17, 07:00

  3. TYPO3com voted on patch set 2 V -1 09/01/17, 07:00 Completed build in 06s on Fri, 1 Sep, 09:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14169

  4. TYPO3com commented on patch set 2 09/01/17, 12:35 Completed build in 01m 13s on Fri, 1 Sep, 02:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14169

  5. Benni Mack uploaded patch set 3 09/01/17, 13:09

  6. TYPO3com voted on patch set 3 V -1 09/01/17, 13:24 Completed build in 14m 49s on Fri, 1 Sep, 03:24 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173

  7. TYPO3com commented on patch set 3 09/02/17, 18:34 Completed build in 5h 40m 00s on Sat, 2 Sep, 08:34 PM Test Summary: 3 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173

  8. TYPO3com commented on patch set 3 09/02/17, 18:37 Completed build in 11h 07m 32s on Sat, 2 Sep, 08:37 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173

  9. TYPO3com commented on patch set 3 09/05/17, 13:12 Completed build in 11h 09m 59s on Tue, 5 Sep, 03:12 PM Test Summary: 2 of 58424 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14173

  10. Benni Mack uploaded patch set 4 09/05/17, 14:01

  11. TYPO3com voted on patch set 4 V -1 09/05/17, 14:01 Completed build in 10s on Tue, 5 Sep, 04:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14223

  12. Benni Mack uploaded patch set 5 09/05/17, 14:01

  13. TYPO3com voted on patch set 5 V -1 09/05/17, 14:24 Completed build in 22m 50s on Tue, 5 Sep, 04:24 PM Test Summary: 2 of 58440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14224

  14. TYPO3com voted on patch set 5 V +1 09/05/17, 15:57 Completed build in 2h 18m 03s on Tue, 5 Sep, 05:57 PM Test Summary: 58077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14224

  15. Mona Muzaffar commented on patch set 5 V +1 09/06/17, 19:05

    AbstractAction.php:154

    redundant description since you added a new one

    AbstractAction.php:158

    small typo 'creataes'.
  16. Mona Muzaffar commented on patch set 5 09/06/17, 19:13

    small typo 'your' instead of 'you'
  17. Stefan Neufeind commented on patch set 5 V +1 09/07/17, 07:13

    verified it's usable through the backend as well as standalone basic review of the code (though I'll not call that "code-review" for the moment)
  18. Markus Hölzle commented on patch set 5 09/07/17, 08:50

    AbstractAction.php:162

    I would add PHP7 type declaration "string"

    ActionInterface.php:56

    I would add PHP7 type declaration "string"

    ContextService.php:32

    I would add PHP7 type declaration "string"
  19. Markus Hölzle voted on patch set 5 V +1 09/07/17, 08:54

  20. Romain Canon uploaded patch set 6 09/07/17, 13:34

  21. TYPO3com voted on patch set 6 V -1 09/07/17, 13:54 Completed build in 20m 32s on Thu, 7 Sep, 03:54 PM Test Summary: 1 of 58494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14305

  22. Romain Canon commented on patch set 6 CR +1 V +1 09/07/17, 14:05

    Works fine, some old code/files should probably be removed when this patch is merged.
  23. TYPO3com voted on patch set 6 V +1 09/07/17, 14:12 Completed build in 58m 51s on Thu, 7 Sep, 04:12 PM Test Summary: 58131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14305

  24. Andreas Kienast voted on patch set 6 CR +2 V +2 09/07/17, 14:40

  25. Gerrit merged patch set 6 09/07/17, 14:40