Review TYPO3_7-6 Merged

53878[BUGFIX] Check if LocalConfiguration.php is writable

Benni Mack CR +2 V +2 Easy +1 −1 updated 09/05/17, 07:51

Commit message

In TYPO3 v8, the ConfigurationManager only checks if LocalConfiguration.php
is writaeble and not if typo3conf itself is writable.

Optimizing this check removes a warning in an environment where typo3conf/
is hardened to only have LocalConfiguration.php be modified and nothing else.
This change helps running TYPO3 v7 on platform.sh with fewer error messages.

You can compare this line of code with the same line in TYPO3 v8/master.

Review

  • Code review CR +2
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 09/04/17, 15:13

  2. TYPO3com voted on patch set 1 V +1 09/04/17, 15:19 Completed build in 05m 58s on Mon, 4 Sep, 05:19 PM Test Summary: 39152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1090

  3. Susi Moog voted on patch set 1 CR +1 09/04/17, 17:49

  4. Andreas Kienast updated the commit message in patch set 2 09/05/17, 06:36

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 09/05/17, 06:36

  6. TYPO3com voted on patch set 2 V +1 09/05/17, 06:41 Completed build in 05m 08s on Tue, 5 Sep, 08:41 AM Test Summary: 39152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1091

  7. Susi Moog voted on patch set 2 CR +2 V +2 09/05/17, 07:48

  8. Gerrit merged patch set 2 09/05/17, 07:51