Review TYPO3_8-7 Abandoned

53888[TASK] Fix versions in composer.json and ext_emconf.php

Benni Mack CR 0 V 0 Normal +107 −107 updated 09/05/17, 07:59

Commit message

This patch hardens the versions of dependencies in ext_emconf.php and
composer.json (where previously "*" was set).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 94

Show 74 more files

Review log 913

  1. Benni Mack uploaded patch set 1 09/05/17, 06:04

  2. TYPO3com voted on patch set 1 V -1 09/05/17, 06:17 Completed build in 12m 57s on Tue, 5 Sep, 08:17 AM Test Summary: 1 of 59318 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-796

  3. TYPO3com voted on patch set 1 V +1 09/05/17, 06:39 Completed build in 48m 28s on Tue, 5 Sep, 08:39 AM Test Summary: 58954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-796

  4. Helmut Hummel voted on patch set 1 CR +1 V +1 09/05/17, 07:00

  5. Helmut Hummel commented on patch set 1 CR 0 09/05/17, 07:07

    releases should be 8.7
  6. Mathias Brodala commented on patch set 1 09/05/17, 07:10

    Is there already a script in place which takes cafe of updating this on release?
  7. Benni Mack updated the commit message in patch set 2 09/05/17, 07:13

  8. Benni Mack commented on patch set 2 09/05/17, 07:14

    @mbrodala. yes.
  9. Mathias Brodala commented on patch set 2 09/05/17, 07:17

    composer.json:11

    While we're at it, should this be changed too?

    composer.json:14

    Same here?
  10. TYPO3com voted on patch set 2 V -1 09/05/17, 07:27 Completed build in 13m 10s on Tue, 5 Sep, 09:27 AM Test Summary: 2 of 59318 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-797

  11. TYPO3com voted on patch set 2 V +1 09/05/17, 07:47 Completed build in 46m 56s on Tue, 5 Sep, 09:47 AM Test Summary: 58954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-797

  12. Helmut Hummel commented on patch set 2 CR -2 09/05/17, 07:56

    composer.json:11 Reply

    No. The * is intentional here. If this is installed individually, typo3/cms in any version must not be installed

    composer.json:14 Reply

    same goes for replace section
  13. Benni Mack abandoned the change 09/05/17, 07:59

    ok. we use the other one