53891[BUGFIX] Add composer dependencies to individual packages
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Helmut Hummel uploaded patch set 1 09/05/17, 08:57
-
Susi Moog voted on patch set 1 CR +1 09/05/17, 09:09
-
TYPO3com voted on patch set 1 V -1 09/05/17, 09:09 Completed build in 12m 25s on Tue, 5 Sep, 11:09 AM Test Summary: 1 of 59318 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-800
-
TYPO3com voted on patch set 1 V +1 09/05/17, 09:18 Completed build in 33m 23s on Tue, 5 Sep, 11:18 AM Test Summary: 58954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-800
-
Benni Mack voted on patch set 1 CR +1 V +1 09/05/17, 09:19
-
Susi Moog voted on patch set 1 V +1 09/05/17, 09:22
-
Benni Mack voted on patch set 1 CR +2 V +2 09/05/17, 09:32
-
Gerrit merged patch set 1 09/05/17, 09:38
-
Benjamin Franzke commented on patch set 2 09/06/17, 07:37
This patch was only merged to the TYPO3_8-7 branch, but not to master. By intent? One question regarding the patch itself: The splitted packages will use transitive dependencies (implicitly through typo3/cms-core). Have you discussed/decided whether TYPO3 (core) extensions should generally use transitive dependencies (easier to maintain) or direct dependencies for every splitted package (more formally correct)? My assumption regarding the redundancy between /composer.json and /typo3/sysext/core/composer.json is, that there will be bugs (soon) because dependency updates have only been added to one of these files. I assume someone will write a composer.json-merger to merge the individual composer.json's from /typo3/sysext/*/composer.json to the root /composer.json. With that in mind explicit dependencies in every subpackage might be an option. What do you think? -
Benni Mack commented on patch set 2 09/06/17, 07:48
Thanks for your feedback. 1. Yes, we are currently in testing phase of separated packages and need proper tags for that ;) So we needed to take quick action for 8.7.5, and now do further tests on that. The changes for master will also follow soon. 2. We currently try to find a solution for v8 (starting with 8.7.6 I'd say) and then continue our way towards master. For master/v9 this needs to be sorted out by a clean structure of "what is depending on what", especially also between system extensions. Since no extension can run without typo3/cms-core, we moved it there for the sake of simplicity, but will continue to see what core actually needs, and the other parts will need. For a streamlined "let's not diverge the composer.jsons" we do need proper documentation and checks to ensure that all runs smooth. If you want to join the efforts, contact me or Helmut in the composer channel on slack, I'd say. -
Stephan Großberndt commented on patch set 2 12/20/17, 16:40
This is still only merged in 8.7 but not in master. Whats the status here? -
Stephan Großberndt commented on patch set 2 02/19/18, 20:45
Ping -
Benni Mack commented on patch set 2 02/20/18, 07:39
This has been fixed separately in 8.7 -
Stephan Großberndt commented on patch set 2 02/20/18, 10:53
The according change in master was done in https://review.typo3.org/#/c/55000/