53923[TASK] Move DefaultConfigurationDescription to Yaml format
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Mona Muzaffar +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.phpdeleted+0 −185
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml6new+498 −0
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php1+40 −43
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Settings/LocalConfiguration/SubSection.html+55 −40
Review log 1316
-
Benni Mack uploaded patch set 1 09/06/17, 05:14
-
TYPO3com voted on patch set 1 V +1 09/06/17, 05:32 Completed build in 17m 58s on Wed, 6 Sep, 07:32 AM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14243
-
Mona Muzaffar voted on patch set 1 V +1 09/06/17, 06:32
-
Wouter Wolters voted on patch set 1 CR +1 09/06/17, 06:47
-
Mona Muzaffar commented on patch set 1 CR +1 09/06/17, 07:14
DefaultConfigurationDescription.yaml:155couldn't this be of type listDefaultConfigurationDescription.yaml:293couldn't this also be a dropdown if only 'normal' and 'rsa' are allowedDefaultConfigurationDescription.yaml:321maybe here also a dropdown instead of a textDefaultConfigurationDescription.yaml:413list instead of text? -
Mathias Brodala commented on patch set 1 09/06/17, 07:23
LocalConfigurationValueService.php:175How about using our existing YamlFileLoader here? -
Benni Mack commented on patch set 1 09/06/17, 10:08
thanks for your feedback, will provide an updated patch. -
Benni Mack commented on patch set 1 09/06/17, 10:22
DefaultConfigurationDescription.yaml:293Replycan be others too (if an extension is installed which allows for more) -
Benni Mack uploaded patch set 2 09/06/17, 10:26
-
TYPO3com voted on patch set 2 V -1 09/06/17, 10:26 Completed build in 10s on Wed, 6 Sep, 12:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14252
-
Benni Mack uploaded patch set 3 09/06/17, 10:27
-
TYPO3com voted on patch set 3 V +1 09/06/17, 10:43 Completed build in 15m 13s on Wed, 6 Sep, 12:43 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14253
-
Mona Muzaffar voted on patch set 3 CR +1 V +1 09/06/17, 13:10
-
Stefan Neufeind voted on patch set 3 CR +1 V +1 09/07/17, 08:00
-
Benni Mack voted on patch set 3 CR +2 V +2 09/07/17, 08:20
-
Gerrit merged patch set 3 09/07/17, 08:20
DefaultConfigurationDescription.yaml:101