Review main Merged

53923[TASK] Move DefaultConfigurationDescription to Yaml format

Benni Mack CR +2 V +2 Hard +594 −269 updated 09/07/17, 08:20

Commit message

Defining all configuration options in TYPO3 Install Tool is now handled
via a Yaml file which additionally specifies the "type" of the configuration
option, allowing to use further render settings, one of them already introduced
for "allowedValues". This moves the "All Configuration" to a more flexible output
rendering of dropdowns for a specific type.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Mona Muzaffar +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1316

  1. Benni Mack uploaded patch set 1 09/06/17, 05:14

  2. TYPO3com voted on patch set 1 V +1 09/06/17, 05:32 Completed build in 17m 58s on Wed, 6 Sep, 07:32 AM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14243

  3. Mona Muzaffar voted on patch set 1 V +1 09/06/17, 06:32

  4. Wouter Wolters voted on patch set 1 CR +1 09/06/17, 06:47

  5. Mona Muzaffar commented on patch set 1 CR +1 09/06/17, 07:14

    DefaultConfigurationDescription.yaml:101

    couldn't this also be an int?

    DefaultConfigurationDescription.yaml:155

    couldn't this be of type list

    DefaultConfigurationDescription.yaml:293

    couldn't this also be a dropdown if only 'normal' and 'rsa' are allowed

    DefaultConfigurationDescription.yaml:321

    maybe here also a dropdown instead of a text

    DefaultConfigurationDescription.yaml:413

    list instead of text?
  6. Mathias Brodala commented on patch set 1 09/06/17, 07:23

    LocalConfigurationValueService.php:175

    How about using our existing YamlFileLoader here?
  7. Benni Mack commented on patch set 1 09/06/17, 10:08

    thanks for your feedback, will provide an updated patch.
  8. Benni Mack commented on patch set 1 09/06/17, 10:22

    DefaultConfigurationDescription.yaml:293 Reply

    can be others too (if an extension is installed which allows for more)
  9. Benni Mack uploaded patch set 2 09/06/17, 10:26

  10. TYPO3com voted on patch set 2 V -1 09/06/17, 10:26 Completed build in 10s on Wed, 6 Sep, 12:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14252

  11. Benni Mack uploaded patch set 3 09/06/17, 10:27

  12. TYPO3com voted on patch set 3 V +1 09/06/17, 10:43 Completed build in 15m 13s on Wed, 6 Sep, 12:43 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14253

  13. Mona Muzaffar voted on patch set 3 CR +1 V +1 09/06/17, 13:10

  14. Stefan Neufeind voted on patch set 3 CR +1 V +1 09/07/17, 08:00

  15. Benni Mack voted on patch set 3 CR +2 V +2 09/07/17, 08:20

  16. Gerrit merged patch set 3 09/07/17, 08:20