53926[BUGFIX] Unify Extbase base command error
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Alexander Schnitzler +1
-
Verified V +2
- Helmut Hummel +2
- Stefan Neufeind +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 3036
Show 911 earlier messages
-
Alexander Schnitzler uploaded patch set 1 09/06/17, 09:39
-
Alexander Schnitzler updated the commit message in patch set 2 09/06/17, 09:40
-
TYPO3com voted on patch set 1 V -1 09/06/17, 09:57 Completed build in 18m 05s on Wed, 6 Sep, 11:57 AM Test Summary: 1 of 58442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14249
-
TYPO3com voted on patch set 2 V +1 09/06/17, 10:01 Completed build in 20m 42s on Wed, 6 Sep, 12:01 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14250
-
Wouter Wolters voted on patch set 2 CR +1 09/06/17, 18:00
-
Stefan Neufeind voted on patch set 2 CR +1 V +1 09/07/17, 06:59
-
Jan Helke voted on patch set 2 CR +1 09/10/17, 11:12
-
Helmut Hummel commented on patch set 2 V -1 09/18/17, 09:24
The result of "typo3 backend" significantly differs from "typo3 extbase" after this change (and of course before this change) Is the intention to unify this or to only fix the not speaking error message when calling "typo3 extbase"?calling this $ typo3/sysext/core/bin/typo3 backend leads to this error: [Symfony\Component\Console\Exception\CommandNotFoundException] Command "backend" is not defined. Did you mean one of these? backend:unlock backend:lock So this patch fixes this only for Extbase commands/ command controllers? -
Alexander Schnitzler commented on patch set 2 09/18/17, 09:29
Reply
Yes indeed. Benni introduced that command as a bridge while migrating away from command controllers. I am not sure if the plan is to keep that command for long and implement it properly so it outputs the default help of the symfony console. For now it should only fix throwing the exception. -
Helmut Hummel commented on patch set 2 09/18/17, 09:33
Reply
My point is, that Symfony does not output a help message, but an error message. So question is: what do we want in the future for both command types? -
Alexander Schnitzler commented on patch set 2 09/18/17, 09:35
Reply
I'd opt for the default handling of symfony console.
-
Stefan Neufeind commented on patch set 2 09/18/17, 09:43
I'm fine either way. It's just that the exception looks weird. -
Alexander Schnitzler commented on patch set 2 09/18/17, 09:48
The thing is this: Currently we have a misleading exception people don't know how to cope with. While I'd like to implement the default behaviour of unregistered commands here as well, I don't think it's easily done as we actually use that command. This patch is an improvement as it displays the available commands just like symfony console would do, only the style is different. -
Helmut Hummel commented on patch set 2 CR -1 V 0 09/18/17, 09:51
> This patch is an improvement as it displays the available commands just like symfony console would do, only the style is different I agree. If you change the commit message accordingly, I'm very fine to get it in -
Helmut Hummel commented on patch set 2 09/18/17, 09:52
Reply
cool. we agree on that :) Can you change the commit message to reflect this? -
Alexander Schnitzler commented on patch set 2 09/18/17, 09:52
Sorry, but I don't really get what's wrong with the commit message. -
Helmut Hummel updated the commit message in patch set 3 09/18/17, 10:00
-
Helmut Hummel updated the commit message in patch set 4 09/18/17, 10:00
-
Helmut Hummel commented on patch set 4 CR +1 V +1 09/18/17, 10:01
here is my commit message suggestion -
Stefan Neufeind updated the commit message in patch set 5 09/18/17, 10:02
-
Stefan Neufeind voted on patch set 5 CR +1 V +1 09/18/17, 10:02
-
Helmut Hummel voted on patch set 5 CR +1 V +1 09/18/17, 10:03
-
TYPO3com voted on patch set 3 V -1 09/18/17, 10:20 Completed build in 19m 39s on Mon, 18 Sep, 12:20 PM Test Summary: 1 of 58557 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15005
-
Helmut Hummel commented on patch set 5 CR -1 09/18/17, 10:21
hm, give me a minute to check sth -
TYPO3com voted on patch set 4 V +1 09/18/17, 10:24 Completed build in 23m 43s on Mon, 18 Sep, 12:24 PM Test Summary: 58194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15006
-
TYPO3com voted on patch set 5 V +1 09/18/17, 10:26 Completed build in 24m 31s on Mon, 18 Sep, 12:26 PM Test Summary: 58194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15007
-
Helmut Hummel uploaded patch set 6 09/18/17, 10:43
-
Helmut Hummel commented on patch set 6 09/18/17, 10:44
How about that? Do you agree with backporting this to 8.7? -
Stefan Neufeind commented on patch set 6 V +1 09/18/17, 10:55
hmm, we don't need the command "extbase" under that name in the array? Result looks fine for me. I'd be fine with 8.7 as well, if you say we don't risk something (it's not needed in the array under that key). -
Helmut Hummel commented on patch set 6 09/18/17, 10:59
> hmm, we don't need the command "extbase" under that name in the array? well, you saw the result of calling this command directly. Thing is, it isn't meant to be called directly but just to add command controller commands to the application. That's why it never had the execute method implemented -
TYPO3com voted on patch set 6 V +1 09/18/17, 11:00 Completed build in 16m 23s on Mon, 18 Sep, 01:00 PM Test Summary: 58194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15010
-
Stefan Neufeind voted on patch set 6 CR +1 09/18/17, 11:15
-
Alexander Schnitzler commented on patch set 6 CR +1 V +1 09/18/17, 11:51
That looks even better. Great and simple solution. -
Helmut Hummel voted on patch set 6 CR +2 V +2 09/18/17, 11:59
-
Gerrit merged patch set 6 09/18/17, 11:59
-
Helmut Hummel commented on patch set 7 09/18/17, 11:59
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5f7a888a03dabfd659694ae46f286c35f68519e7