Review main Merged

5394[BUGFIX] skip missing icons in tceforms select options

Peter Niederlag CR +2 V +2 Easy +9 −2 updated 06/03/13, 20:49

Commit message

check existance of file before adding background style url

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Björn Pedersen +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2
    • Markus Klein +1

Files 1

Review log 10

  1. Peter Niederlag uploaded patch set 2 10/17/11, 08:29

  2. Björn Pedersen commented on patch set 2 10/17/11, 08:29

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 2 10/17/11, 08:29

    Looks good to me, but someone else must approve trivial
  4. Markus Klein commented on patch set 2 10/17/11, 08:29

    Verified; Looks good to me, but someone else must approve Thanks for this Peter!
  5. Xavier Perseguers commented on patch set 2 V 0 10/17/11, 08:29

    by team member; Looks good to me, approved
  6. Philipp Gampe commented on patch set 1 10/17/11, 08:29

    (2 inline comments) I am not sure about CGL, but I think we always use brackets for if.
    Please use capital S also for C below

    class.t3lib_tceforms.php:4067

    I think we always use Brackets
  7. Philipp Gampe commented on patch set 2 10/17/11, 08:29

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 10/17/11, 08:29

  9. Mr. Jenkins commented on patch set 2 10/17/11, 08:29

  10. Xavier Perseguers merged patch set 2 10/17/11, 08:29