5394[BUGFIX] skip missing icons in tceforms select options
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Björn Pedersen +1
- Markus Klein +1
- Philipp Gampe +1
-
Verified V +2
- Xavier Perseguers +2
- Markus Klein +1
Files 1
Review log 10
-
Peter Niederlag uploaded patch set 2 10/17/11, 08:29
-
Björn Pedersen commented on patch set 2 10/17/11, 08:29
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 10/17/11, 08:29
Looks good to me, but someone else must approve trivial -
Markus Klein commented on patch set 2 10/17/11, 08:29
Verified; Looks good to me, but someone else must approve Thanks for this Peter! -
Xavier Perseguers commented on patch set 2 V 0 10/17/11, 08:29
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 10/17/11, 08:29
(2 inline comments) I am not sure about CGL, but I think we always use brackets for if.Please use capital S also for C belowclass.t3lib_tceforms.php:4067I think we always use Brackets -
Philipp Gampe commented on patch set 2 10/17/11, 08:29
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 10/17/11, 08:29
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1974/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/17/11, 08:29
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1975/ : SUCCESS -
Xavier Perseguers merged patch set 2 10/17/11, 08:29