Review main Merged

53940[BUGFIX] Do not use LIMIT/OFFSET on total count query

Susi Moog CR +2 V +2 Easy +3 −0 updated 09/08/17, 03:24

Commit message

Usage of limit > 0 or offset in a count query do not
make sense and result in broken pagination in the list
module as the returned total count of items is always 0.

Reset given offsets/limit for that exact query.

Review

  • Code review CR +2
    • Georg Ringer +2
    • simonbrandstaetter +1
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • simonbrandstaetter +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Susi Moog uploaded patch set 1 09/07/17, 08:30

  2. simonbrandstaetter commented on patch set 1 CR +1 V +1 09/07/17, 08:42

    Thank you tried it. Works
  3. TYPO3com voted on patch set 1 V +1 09/07/17, 08:53 Completed build in 23m 03s on Thu, 7 Sep, 10:53 AM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14283

  4. Wouter Wolters voted on patch set 1 CR +1 09/07/17, 08:54

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 09/07/17, 10:33

  6. Andreas Kienast voted on patch set 1 CR +1 09/07/17, 10:49

  7. Georg Ringer voted on patch set 1 CR +2 V +2 09/07/17, 11:03

  8. Gerrit merged patch set 1 09/07/17, 11:03

  9. Georg Ringer commented on patch set 2 09/08/17, 03:24

    backport not needed as code differnt in 8-7