Review TYPO3_8-7 Merged

53942[BUGFIX] EXT:form - catch exceptions within page module and form engine

Frans Saris CR +2 V +2 Normal +186 −36 updated 09/07/17, 13:01

Commit message

* Show messages within page module and form engine if the backend user
does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
ext:form configuration is invalid.

Review

  • Code review CR +2
    • Frans Saris +2
    • Thomas Kieslich +1
    • Björn Jacob +1
    • Martin Kutschker +1
  • Verified V +2
    • Frans Saris +2
    • Thomas Kieslich +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 911

  1. Frans Saris uploaded patch set 1 09/07/17, 09:45

  2. Martin Kutschker voted on patch set 1 CR +1 09/07/17, 09:58

  3. TYPO3com voted on patch set 1 V -1 09/07/17, 10:03 Completed build in 17m 15s on Thu, 7 Sep, 12:03 PM Test Summary: 1 of 59390 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-828

  4. Björn Jacob voted on patch set 1 CR +1 V +1 09/07/17, 10:43

  5. TYPO3com voted on patch set 1 V +1 09/07/17, 10:54 Completed build in 1h 26m 04s on Thu, 7 Sep, 12:54 PM Test Summary: 59026 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-828

  6. Thomas Kieslich voted on patch set 1 CR +1 V +1 09/07/17, 12:31

  7. Frans Saris voted on patch set 1 CR +2 V +2 09/07/17, 12:38

  8. Gerrit merged patch set 1 09/07/17, 12:38

  9. Claus Due commented on patch set 2 09/07/17, 12:41

    Wouldn't it have made sense to check the debug/error handler settings here, or pass this through the errorhandler itself somehow, to facilitate debugging these errors on development contexts?
  10. Frans Saris commented on patch set 2 09/07/17, 13:00

    That would indeed be a nice addition
  11. Björn Jacob commented on patch set 2 09/07/17, 13:01

    Maybe Claus can create a new issues (as task) and provide something for this issue?