Review main Merged Breaking

53947[!!!][TASK] Decouple classes extending AbstractRecordList

Matthias Vogel CR +2 V +2 Nightmare +4354 −23 updated 01/31/18, 14:18

Commit message

In order to refactor the page module, list module,
and the file module individually,
the classes should become independent from each other.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2035

Show 610 earlier messages
  1. Matthias Vogel uploaded patch set 1 09/07/17, 12:45

  2. TYPO3com voted on patch set 1 V -1 09/07/17, 12:47 Completed build in 02m 22s on Thu, 7 Sep, 02:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14298

  3. Matthias Vogel uploaded patch set 2 09/07/17, 13:35

  4. Matthias Vogel commented on patch set 2 V -1 09/07/17, 13:36

    WIP
  5. TYPO3com voted on patch set 2 V -1 09/07/17, 13:53 Completed build in 18m 02s on Thu, 7 Sep, 03:53 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14306

  6. Matthias Vogel uploaded patch set 3 09/07/17, 14:00

  7. Matthias Vogel uploaded patch set 4 09/07/17, 14:11

  8. TYPO3com voted on patch set 3 V -1 09/07/17, 14:16 Completed build in 16m 30s on Thu, 7 Sep, 04:16 PM Test Summary: 1 of 58496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14311

  9. Matthias Vogel uploaded patch set 5 09/07/17, 14:16

  10. TYPO3com voted on patch set 4 V -1 09/07/17, 14:32 Completed build in 20m 11s on Thu, 7 Sep, 04:32 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14312

  1. TYPO3com voted on patch set 5 V +1 09/07/17, 14:38 Completed build in 21m 12s on Thu, 7 Sep, 04:38 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14314

  2. Simon Praetorius uploaded patch set 6 09/07/17, 15:08

  3. TYPO3com voted on patch set 6 V +1 09/07/17, 15:33 Completed build in 25m 25s on Thu, 7 Sep, 05:33 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14326

  4. Anja Leichsenring updated the commit message in patch set 7 09/07/17, 17:47

  5. TYPO3com voted on patch set 7 V -1 09/07/17, 18:03 Completed build in 15m 34s on Thu, 7 Sep, 08:03 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14355

  6. Anja Leichsenring commented on patch set 7 09/07/17, 18:06

    AbstractRecordList.php:198

    remove the - see method usages from the methods?
  7. TYPO3com voted on patch set 7 V +1 09/07/17, 18:09 Completed build in 37m 28s on Thu, 7 Sep, 08:09 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14355

  8. Matthias Vogel uploaded patch set 8 09/07/17, 18:21

  9. TYPO3com voted on patch set 8 V -1 09/07/17, 18:44 Completed build in 23m 16s on Thu, 7 Sep, 08:44 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14360

  10. TYPO3com commented on patch set 8 09/07/17, 18:48 Completed build in 50m 49s on Thu, 7 Sep, 08:48 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14360

  11. Matthias Vogel uploaded patch set 9 09/08/17, 08:10

  12. Matthias Vogel uploaded patch set 10 09/08/17, 08:17

  13. TYPO3com voted on patch set 9 V -1 09/08/17, 08:25 Completed build in 14m 58s on Fri, 8 Sep, 10:25 AM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14399

  14. TYPO3com voted on patch set 10 V +1 09/08/17, 08:33 Completed build in 16m 32s on Fri, 8 Sep, 10:33 AM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14400

  15. Matthias Vogel uploaded patch set 11 09/08/17, 10:27

  16. Christian Kuhn uploaded patch set 12 09/08/17, 10:53

  17. Christian Kuhn updated the commit message in patch set 13 09/08/17, 10:54

  18. TYPO3com voted on patch set 11 V -1 09/08/17, 11:37 Completed build in 1h 09m 51s on Fri, 8 Sep, 01:37 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14437

  19. Andreas Kienast uploaded patch set 14 09/08/17, 11:54

  20. TYPO3com voted on patch set 13 V -1 09/08/17, 11:56 Completed build in 1h 01m 34s on Fri, 8 Sep, 01:56 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14446

  21. TYPO3com voted on patch set 14 V +1 09/08/17, 12:28 Completed build in 34m 03s on Fri, 8 Sep, 02:28 PM Test Summary: 56821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14457

  22. Christian Kuhn voted on patch set 14 CR +1 V +1 09/08/17, 12:33

  23. Andreas Kienast voted on patch set 14 CR +2 V +2 09/08/17, 12:46

  24. Gerrit merged patch set 14 09/08/17, 12:46

  25. Frank Nägler commented on patch set 15 01/31/18, 14:18

    post -1. this patch has bad side effect: 1) In three classes the same hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][DatabaseRecordList::class]['buildQueryParameters'] is used 2) the sixth parameter ($this) refer to one of this three classes, alle three classes has no common abstract parent class nor a common interface The result: I have no change to write clean code, because I can't add a type hint for the buildQueryParametersPostProcess method. Beside this points, it is no good idea to use the same hook in different places with different method signatures. The bug report: https://forge.typo3.org/issues/83740