Review main Merged

53949[BUGFIX] EXT:form - fix page drag & drop

Ralf Zimmermann CR +2 V +2 Easy +11 −0 updated 09/07/17, 15:31

Commit message

Fix JavaScript errors on page drag & drop within the form editor

Review

  • Code review CR +2
    • Oliver Hader +2
    • Daniel Gohlke +1
    • Carlos Meyer +1
  • Verified V +2
    • Oliver Hader +2
    • Daniel Gohlke +1
    • Carlos Meyer +1

Issues 1

Files 1

Review log 1216

  1. Ralf Zimmermann uploaded patch set 1 09/07/17, 13:30

  2. TYPO3com voted on patch set 1 V -1 09/07/17, 13:53 Completed build in 23m 01s on Thu, 7 Sep, 03:53 PM Test Summary: 1 of 58496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14304

  3. TYPO3com voted on patch set 1 V +1 09/07/17, 14:00 Completed build in 53m 21s on Thu, 7 Sep, 04:00 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14304

  4. Carlos Meyer voted on patch set 1 CR +1 V +1 09/07/17, 14:22

  5. Daniel Gohlke voted on patch set 1 CR +1 V +1 09/07/17, 14:51

  6. Oliver Hader uploaded patch set 2 09/07/17, 15:05

  7. Oliver Hader commented on patch set 2 09/07/17, 15:06

    Just refactored to have an early return here
  8. Oliver Hader voted on patch set 2 CR +1 V +1 09/07/17, 15:06

  9. Oliver Hader uploaded patch set 3 09/07/17, 15:08

  10. Daniel Gohlke voted on patch set 3 CR +1 V +1 09/07/17, 15:10

  11. Carlos Meyer voted on patch set 3 CR +1 V +1 09/07/17, 15:12

  12. Oliver Hader voted on patch set 3 CR +2 V +2 09/07/17, 15:14

  13. Gerrit merged patch set 3 09/07/17, 15:14

  14. Oliver Hader commented on patch set 4 09/07/17, 15:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e7c25052346c7e8fd47c026cce18346db2e32d12
  15. TYPO3com commented on patch set 2 09/07/17, 15:28 Completed build in 22m 53s on Thu, 7 Sep, 05:28 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14324

  16. TYPO3com commented on patch set 3 09/07/17, 15:31 Completed build in 23m 02s on Thu, 7 Sep, 05:31 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14325