Review main Merged

53953[TASK] Use TYPO3_OS constant in Services registration

Benni Mack CR +2 V +2 Easy +2 −3 updated 09/08/17, 21:38

Commit message

There is a comment that TYPO3_OS is not yet defined, which
is wrong as it is one of the first things available during bootstrap,
so the check can be used directly.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 09/07/17, 14:25

  2. Wouter Wolters voted on patch set 1 CR +1 09/07/17, 14:32

  3. TYPO3com voted on patch set 1 V +1 09/07/17, 14:45 Completed build in 19m 57s on Thu, 7 Sep, 04:45 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14316

  4. Stefan Neufeind voted on patch set 1 CR +1 09/08/17, 10:05

  5. Andreas Kienast voted on patch set 1 CR +1 09/08/17, 10:08

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 09/08/17, 21:37

  7. Gerrit merged patch set 1 09/08/17, 21:37

  8. Christian Kuhn commented on patch set 2 09/08/17, 21:38

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6e2bf895d39187695328b35cef231b0fcd17306c