Review main Merged

53956[BUGFIX] EXT:form - fix values with dots within form editor

Ralf Zimmermann CR +2 V +2 Easy +2 −0 updated 09/08/17, 08:27

Commit message

Fix JavaScript errors if "properties.options" array keys contain dots.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Daniel Gohlke +1
  • Verified V +2
    • Oliver Hader +2
    • Daniel Gohlke +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 4

Files 1

Review log 1927

Show 2 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 09/07/17, 15:16

  2. Mathias Brodala updated the commit message in patch set 2 09/07/17, 15:29

  1. Daniel Gohlke voted on patch set 2 CR +1 V +1 09/07/17, 15:35

  2. TYPO3com voted on patch set 1 V -1 09/07/17, 15:41 Completed build in 25m 07s on Thu, 7 Sep, 05:41 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14327

  3. TYPO3com voted on patch set 1 V +1 09/07/17, 15:44 Completed build in 52m 57s on Thu, 7 Sep, 05:44 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14327

  4. TYPO3com voted on patch set 2 V +1 09/07/17, 15:50 Completed build in 21m 27s on Thu, 7 Sep, 05:50 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14331

  5. Björn Jacob updated the commit message in patch set 3 09/07/17, 16:14

  6. Mathias Brodala voted on patch set 3 V +1 09/07/17, 16:15

  7. Martin Kutschker commented on patch set 2 09/07/17, 16:17

    On 8.7 the patch doesn't fix #82210 for me.
  8. Oliver Hader commented on patch set 3 09/07/17, 16:24

    Core.js:722

    can be simplified to "else if .. else"
  9. Oliver Hader uploaded patch set 4 09/07/17, 16:27

  10. Oliver Hader uploaded patch set 5 09/07/17, 16:29

  11. TYPO3com voted on patch set 3 V +1 09/07/17, 16:32 Completed build in 17m 28s on Thu, 7 Sep, 06:32 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14335

  12. Daniel Gohlke voted on patch set 5 CR +1 V +1 09/07/17, 16:34

  13. TYPO3com voted on patch set 4 V +1 09/07/17, 16:45 Completed build in 17m 47s on Thu, 7 Sep, 06:45 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14337

  14. TYPO3com voted on patch set 5 V +1 09/07/17, 16:47 Completed build in 17m 38s on Thu, 7 Sep, 06:47 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14338

  15. Oliver Hader voted on patch set 5 CR -1 09/07/17, 16:59

  16. Oliver Hader commented on patch set 5 09/07/17, 17:04

    PHP part is missing, will take care
  17. Mathias Brodala updated the commit message in patch set 6 09/07/17, 17:38

  18. Oliver Hader commented on patch set 6 CR +1 V +1 09/07/17, 17:40

    My fault, PHP part is fine - documented the scenario in #80197 with the requirement to adjust YAML configuration. All perfect now
  19. Oliver Hader voted on patch set 6 CR +2 V +2 09/07/17, 17:40

  20. Daniel Gohlke voted on patch set 6 CR +1 V +1 09/07/17, 17:42

  21. Mathias Brodala voted on patch set 6 V +1 09/07/17, 18:00

  22. TYPO3com voted on patch set 6 V -1 09/07/17, 18:05 Completed build in 26m 59s on Thu, 7 Sep, 08:05 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14354

  23. TYPO3com voted on patch set 6 V +1 09/07/17, 18:09 Completed build in 57m 51s on Thu, 7 Sep, 08:09 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14354

  24. Gerrit merged patch set 6 09/07/17, 19:12

  25. Oliver Hader commented on patch set 7 09/08/17, 08:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f234153024f84c4c9de9bac7a4a1d187b1209ca9