53956[BUGFIX] EXT:form - fix values with dots within form editor
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Daniel Gohlke +1
-
Verified V +2
- Oliver Hader +2
- Daniel Gohlke +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 4
- Bug #80197EXT:form - label with periods causes PHP warning
- Bug #82210ext:form multi checkbox values containing . or & result in empty frontend labels
- Bug #81961EXT:form If values in single select field contains dots (f.e. emails) JS saving and rendering fails.
- Bug #82186sysext form: select option triggers php exception under certain conditions
Files 1
Review log 1927
Show 2 earlier messages
-
Daniel Gohlke voted on patch set 2 CR +1 V +1 09/07/17, 15:35
-
TYPO3com voted on patch set 1 V -1 09/07/17, 15:41 Completed build in 25m 07s on Thu, 7 Sep, 05:41 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14327
-
TYPO3com voted on patch set 1 V +1 09/07/17, 15:44 Completed build in 52m 57s on Thu, 7 Sep, 05:44 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14327
-
TYPO3com voted on patch set 2 V +1 09/07/17, 15:50 Completed build in 21m 27s on Thu, 7 Sep, 05:50 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14331
-
Björn Jacob updated the commit message in patch set 3 09/07/17, 16:14
-
Mathias Brodala voted on patch set 3 V +1 09/07/17, 16:15
-
Martin Kutschker commented on patch set 2 09/07/17, 16:17
On 8.7 the patch doesn't fix #82210 for me. -
Oliver Hader commented on patch set 3 09/07/17, 16:24
Core.js:722can be simplified to "else if .. else" -
Oliver Hader uploaded patch set 4 09/07/17, 16:27
-
Oliver Hader uploaded patch set 5 09/07/17, 16:29
-
TYPO3com voted on patch set 3 V +1 09/07/17, 16:32 Completed build in 17m 28s on Thu, 7 Sep, 06:32 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14335
-
Daniel Gohlke voted on patch set 5 CR +1 V +1 09/07/17, 16:34
-
TYPO3com voted on patch set 4 V +1 09/07/17, 16:45 Completed build in 17m 47s on Thu, 7 Sep, 06:45 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14337
-
TYPO3com voted on patch set 5 V +1 09/07/17, 16:47 Completed build in 17m 38s on Thu, 7 Sep, 06:47 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14338
-
Oliver Hader voted on patch set 5 CR -1 09/07/17, 16:59
-
Oliver Hader commented on patch set 5 09/07/17, 17:04
PHP part is missing, will take care -
Mathias Brodala updated the commit message in patch set 6 09/07/17, 17:38
-
Oliver Hader commented on patch set 6 CR +1 V +1 09/07/17, 17:40
My fault, PHP part is fine - documented the scenario in #80197 with the requirement to adjust YAML configuration. All perfect now -
Oliver Hader voted on patch set 6 CR +2 V +2 09/07/17, 17:40
-
Daniel Gohlke voted on patch set 6 CR +1 V +1 09/07/17, 17:42
-
Mathias Brodala voted on patch set 6 V +1 09/07/17, 18:00
-
TYPO3com voted on patch set 6 V -1 09/07/17, 18:05 Completed build in 26m 59s on Thu, 7 Sep, 08:05 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14354
-
TYPO3com voted on patch set 6 V +1 09/07/17, 18:09 Completed build in 57m 51s on Thu, 7 Sep, 08:09 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14354
-
Gerrit merged patch set 6 09/07/17, 19:12
-
Oliver Hader commented on patch set 7 09/08/17, 08:27
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f234153024f84c4c9de9bac7a4a1d187b1209ca9