Review main Merged

53957[TASK] EXT:form - change naming and icon in new content element wizard

Thomas Kieslich CR +2 V +2 Easy +13 −4 updated 09/08/17, 05:35

Commit message

Change language labels and move them to ext:form locallang.xlf.
Change the icon to content-form.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Björn Jacob +1
    • Anja Leichsenring +1
    • Ralf Zimmermann +1
    • Mathias Brodala +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Björn Jacob +1
    • Anja Leichsenring +1
    • Ralf Zimmermann +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1823

  1. Thomas Kieslich uploaded patch set 1 09/07/17, 15:23

  2. TYPO3com voted on patch set 1 V +1 09/07/17, 15:36 Completed build in 13m 15s on Thu, 7 Sep, 05:36 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14328

  3. Björn Jacob updated the commit message in patch set 2 09/07/17, 16:07

  4. Daniel Gohlke commented on patch set 2 09/07/17, 16:13

    IMHO way better. But we could also change the icon which is shown in the edit view. Right now the blue icon is displayed.
  5. TYPO3com voted on patch set 2 V +1 09/07/17, 16:26 Completed build in 18m 40s on Thu, 7 Sep, 06:26 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14334

  6. Mathias Brodala commented on patch set 2 CR -1 09/07/17, 16:42

    Working on it (type icon & CType select icon)
  7. Mathias Brodala uploaded patch set 3 09/07/17, 16:57

  8. Mathias Brodala voted on patch set 3 CR +1 V +1 09/07/17, 16:58

  9. Daniel Gohlke voted on patch set 3 CR +1 V +1 09/07/17, 17:04

  10. Thomas Kieslich voted on patch set 3 CR +1 V +1 09/07/17, 17:06

  11. Björn Jacob voted on patch set 3 CR +1 V +1 09/07/17, 17:08

  12. TYPO3com voted on patch set 3 V +1 09/07/17, 17:15 Completed build in 18m 07s on Thu, 7 Sep, 07:15 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14345

  13. Mathias Brodala commented on patch set 4 09/07/17, 17:18

    Published edit on patch set 3.
  14. Mathias Brodala voted on patch set 4 CR +1 V +1 09/07/17, 17:18

  15. Daniel Gohlke voted on patch set 4 CR +1 V +1 09/07/17, 17:19

  16. Björn Jacob voted on patch set 4 CR +1 V +1 09/07/17, 17:21

  17. TYPO3com voted on patch set 4 V -1 09/07/17, 17:42 Completed build in 23m 39s on Thu, 7 Sep, 07:42 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14348

  18. Ralf Zimmermann voted on patch set 4 CR +1 V +1 09/07/17, 17:42

  19. TYPO3com voted on patch set 4 V +1 09/07/17, 17:45 Completed build in 50m 38s on Thu, 7 Sep, 07:45 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14348

  20. Anja Leichsenring voted on patch set 4 CR +1 V +1 09/07/17, 19:37

  21. Susi Moog voted on patch set 4 CR +2 V +2 09/08/17, 05:34

  22. Gerrit merged patch set 4 09/08/17, 05:34

  23. Susi Moog commented on patch set 5 09/08/17, 05:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 23bc2146348e26e80b2a5d0f6bb23dff80c844e3