53967[FEATURE] Add possibility to get a label in a specific language
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Joerg Kummer +1
- TYPO3com +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst4new+40 −0
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php2+106 −98
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php2+177 −161
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+11 −7
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Fixtures/TranslateViewHelperFixtureForEmptyString.php+3 −1
Review log 2429
Show 24 earlier messages
-
Markus Hölzle uploaded patch set 1 09/07/17, 17:57
-
Matthias Vogel commented on patch set 1 09/07/17, 18:10
-
TYPO3com voted on patch set 1 V -1 09/07/17, 18:12 Completed build in 15m 05s on Thu, 7 Sep, 08:12 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14357
-
TYPO3com voted on patch set 1 V +1 09/07/17, 18:15 Completed build in 33m 18s on Thu, 7 Sep, 08:15 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14357
-
Simon Praetorius voted on patch set 1 CR +1 09/08/17, 11:05
-
Romain Canon commented on patch set 1 CR -1 09/08/17, 13:32
LocalizationUtility.php:98I would not reverse this array as the alternative languages will probably be added in a basic order. If I give this: `['fr', 'de']` I'd like to see `fr` pop first. At this moment, `de` pops first. -
Romain Canon voted on patch set 1 CR +1 09/08/17, 13:33
-
Romain Canon commented on patch set 1 V -1 09/08/17, 13:34
Current behaviour of the "reversed" alternative language keys seems not good to me. -
Markus Hölzle commented on patch set 1 09/09/17, 08:25
> Current behaviour of the "reversed" alternative language keys seems > not good to me. I did not changed the reversed fallback of the languages with this patch, I just added the language as parameter instead of only configure this by typoscript -
Romain Canon commented on patch set 1 V +1 09/09/17, 08:45
> > Current behaviour of the "reversed" alternative language keys > seems > > not good to me. > > I did not changed the reversed fallback of the languages with this > patch, I just added the language as parameter instead of only > configure this by typoscript Ok my bad, did not see that. Maybe we could add a note to the RST file to remind people of this behaviour then? At first sight it can look confusing (as I was when I tested this patch). -
Markus Hölzle commented on patch set 1 CR -1 09/09/17, 10:11
This does not work with "LLL:" keys, I'm on it -
Markus Hölzle uploaded patch set 2 09/09/17, 13:47
-
TYPO3com voted on patch set 2 V +1 09/09/17, 14:06 Completed build in 18m 20s on Sat, 9 Sep, 04:06 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14675
-
Nathan Boiron commented on patch set 2 09/09/17, 17:09
Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25The last 2 arguments are inversed. -
Joerg Kummer commented on patch set 2 V +1 09/09/17, 18:11
Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25I don't think so. Its: key, extensionName, arguments, languageKey, alternativeLanguageKeys In this example just 'languageKey' added to the three existing params -
Nathan Boiron commented on patch set 2 CR +1 09/09/17, 18:12
Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25ReplyOh right, my bad. -
Christian Kuhn commented on patch set 2 CR -1 09/10/17, 07:49
Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:14Try to improve wording a bit: The extbase related LocalizationUtility now supports retrieving the localization of a key in a different language than the initialized language of the given user. This allows for instance rendering a text in french while ... ... something like that (maybe shorter / better). The idea is: You don't describe the process "add some functionality", but "this and that works now in this or that way".LocalizationUtilityTest.php:50i don't like __construct() in tests. it would be better if that preparation could be either in setUp() or called as method in the test(s) directly.LocalizationUtilityTest.php:459could we have some test that runs in one language and then verifies the translation for a different language is corretly fetched? -
Markus Hölzle uploaded patch set 3 09/10/17, 09:07
-
TYPO3com voted on patch set 3 V -1 09/10/17, 09:29 Completed build in 22m 30s on Sun, 10 Sep, 11:29 AM Test Summary: 1 of 58557 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14787
-
TYPO3com voted on patch set 3 V +1 09/10/17, 09:32 Completed build in 48m 06s on Sun, 10 Sep, 11:32 AM Test Summary: 58194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14787
-
Joerg Kummer commented on patch set 3 V +1 09/10/17, 09:43
Tested -
Tymoteusz Motylewski commented on patch set 3 09/11/17, 13:02
related change https://review.typo3.org/#/c/48112/ -
Markus Klein voted on patch set 3 CR +1 09/12/17, 21:55
-
Jigal van Hemert voted on patch set 3 CR +2 V +2 11/03/17, 20:43
-
Gerrit merged patch set 3 11/03/17, 20:43
-
Tymoteusz Motylewski commented on patch set 4 09/18/18, 23:27
Hi do you consider https://forge.typo3.org/issues/86194 a regression? -
Markus Klein commented on patch set 4 09/19/18, 09:16
Yes this is a regression! We use that a lot to define additional labels for ext:news and use them in the template -
Markus Klein commented on patch set 4 09/19/18, 09:17
I overlooked that back then! -
Markus Klein commented on patch set 4 09/21/18, 21:01
LocalizationUtility.php:69