Review main Merged

53967[FEATURE] Add possibility to get a label in a specific language

Markus Hölzle CR +2 V +2 Hard +337 −267 updated 09/21/18, 21:01

Commit message

Add possibility to get a label in a specific language in
LocalizationUtility::translate() and the TranslateViewHelper

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 2429

Show 24 earlier messages
  1. Markus Hölzle uploaded patch set 1 09/07/17, 17:57

  2. Matthias Vogel commented on patch set 1 09/07/17, 18:10

    LocalizationUtility.php:69

    please change to , string $extensionName = null,
  3. TYPO3com voted on patch set 1 V -1 09/07/17, 18:12 Completed build in 15m 05s on Thu, 7 Sep, 08:12 PM Test Summary: 1 of 58488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14357

  4. TYPO3com voted on patch set 1 V +1 09/07/17, 18:15 Completed build in 33m 18s on Thu, 7 Sep, 08:15 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14357

  1. Simon Praetorius voted on patch set 1 CR +1 09/08/17, 11:05

  2. Romain Canon commented on patch set 1 CR -1 09/08/17, 13:32

    LocalizationUtility.php:98

    I would not reverse this array as the alternative languages will probably be added in a basic order. If I give this: `['fr', 'de']` I'd like to see `fr` pop first. At this moment, `de` pops first.
  3. Romain Canon voted on patch set 1 CR +1 09/08/17, 13:33

  4. Romain Canon commented on patch set 1 V -1 09/08/17, 13:34

    Current behaviour of the "reversed" alternative language keys seems not good to me.
  5. Markus Hölzle commented on patch set 1 09/09/17, 08:25

    > Current behaviour of the "reversed" alternative language keys seems > not good to me. I did not changed the reversed fallback of the languages with this patch, I just added the language as parameter instead of only configure this by typoscript
  6. Romain Canon commented on patch set 1 V +1 09/09/17, 08:45

    > > Current behaviour of the "reversed" alternative language keys > seems > > not good to me. > > I did not changed the reversed fallback of the languages with this > patch, I just added the language as parameter instead of only > configure this by typoscript Ok my bad, did not see that. Maybe we could add a note to the RST file to remind people of this behaviour then? At first sight it can look confusing (as I was when I tested this patch).
  7. Markus Hölzle commented on patch set 1 CR -1 09/09/17, 10:11

    This does not work with "LLL:" keys, I'm on it
  8. Markus Hölzle uploaded patch set 2 09/09/17, 13:47

  9. TYPO3com voted on patch set 2 V +1 09/09/17, 14:06 Completed build in 18m 20s on Sat, 9 Sep, 04:06 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14675

  10. Nathan Boiron commented on patch set 2 09/09/17, 17:09

    Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25

    The last 2 arguments are inversed.
  11. Joerg Kummer commented on patch set 2 V +1 09/09/17, 18:11

    Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25

    I don't think so. Its: key, extensionName, arguments, languageKey, alternativeLanguageKeys In this example just 'languageKey' added to the three existing params
  12. Nathan Boiron commented on patch set 2 CR +1 09/09/17, 18:12

    Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:25 Reply

    Oh right, my bad.
  13. Christian Kuhn commented on patch set 2 CR -1 09/10/17, 07:49

    Feature-82354-AddPossibilityToGetALabelInASpecificLanguage.rst:14

    Try to improve wording a bit: The extbase related LocalizationUtility now supports retrieving the localization of a key in a different language than the initialized language of the given user. This allows for instance rendering a text in french while ... ... something like that (maybe shorter / better). The idea is: You don't describe the process "add some functionality", but "this and that works now in this or that way".

    LocalizationUtilityTest.php:50

    i don't like __construct() in tests. it would be better if that preparation could be either in setUp() or called as method in the test(s) directly.

    LocalizationUtilityTest.php:459

    could we have some test that runs in one language and then verifies the translation for a different language is corretly fetched?
  14. Markus Hölzle uploaded patch set 3 09/10/17, 09:07

  15. TYPO3com voted on patch set 3 V -1 09/10/17, 09:29 Completed build in 22m 30s on Sun, 10 Sep, 11:29 AM Test Summary: 1 of 58557 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14787

  16. TYPO3com voted on patch set 3 V +1 09/10/17, 09:32 Completed build in 48m 06s on Sun, 10 Sep, 11:32 AM Test Summary: 58194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14787

  17. Joerg Kummer commented on patch set 3 V +1 09/10/17, 09:43

    Tested
  18. Tymoteusz Motylewski commented on patch set 3 09/11/17, 13:02

  19. Markus Klein voted on patch set 3 CR +1 09/12/17, 21:55

  20. Jigal van Hemert voted on patch set 3 CR +2 V +2 11/03/17, 20:43

  21. Gerrit merged patch set 3 11/03/17, 20:43

  22. Tymoteusz Motylewski commented on patch set 4 09/18/18, 23:27

    Hi do you consider https://forge.typo3.org/issues/86194 a regression?
  23. Markus Klein commented on patch set 4 09/19/18, 09:16

    Yes this is a regression! We use that a lot to define additional labels for ext:news and use them in the template
  24. Markus Klein commented on patch set 4 09/19/18, 09:17

    I overlooked that back then!
  25. Markus Klein commented on patch set 4 09/21/18, 21:01