Review main Merged

53977[TASK] Improve prevention of redirect loop

Christoph Lehmann CR +2 V +2 Easy +1 −1 updated 02/07/18, 18:49

Commit message

This prevents a redirect loop with realurl where an editor
doesn't see the pagetree of his login domain in his workspace
and opens his login domain in the FE. As result he sees the
requested page.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Reiner Teubner +1
    • Steffen Frese +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2226

Show 1 earlier messages
  1. Christoph Lehmann uploaded patch set 1 09/07/17, 20:42

  1. TYPO3com voted on patch set 1 V +1 09/07/17, 21:02 Completed build in 19m 55s on Thu, 7 Sep, 11:02 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14381

  2. Jörg Bösche voted on patch set 1 CR +1 10/09/17, 09:00

  3. Henning Liebe voted on patch set 1 CR +1 10/10/17, 05:57

  4. Sonja Großewinkelmann voted on patch set 1 CR +1 10/16/17, 07:33

  5. Christoph Lehmann rebased onto patch set 2 10/20/17, 22:21

  6. TYPO3com voted on patch set 2 V +1 10/20/17, 22:30 Completed build in 08m 48s on Sat, 21 Oct, 12:30 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15837

  7. Christoph Lehmann commented on patch set 2 10/20/17, 23:04

    Sorry for the noise of rebasing. Nothing changed in the code
  8. Henning Liebe voted on patch set 2 CR +1 10/23/17, 08:53

  9. Benni Mack commented on patch set 3 11/24/17, 21:49

    Published edit on patch set 2.
  10. Benni Mack updated the commit message in patch set 4 11/24/17, 21:50

  11. TYPO3com voted on patch set 3 V +1 11/24/17, 22:04 Completed build in 14m 32s on Fri, 24 Nov, 11:04 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16600

  12. Jörg Bösche voted on patch set 4 CR +1 11/24/17, 22:05

  13. TYPO3com voted on patch set 4 V +1 11/24/17, 22:07 Completed build in 17m 05s on Fri, 24 Nov, 11:07 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16601

  14. Sascha Rademacher voted on patch set 4 CR +1 11/27/17, 09:01

  15. Benni Mack voted on patch set 4 CR +2 11/27/17, 22:38

  16. Henning Liebe voted on patch set 4 CR +1 11/28/17, 08:12

  17. Benni Mack commented on patch set 4 11/29/17, 12:20

    TypoScriptFrontendController.php:2919

    hmm, what if this is an absolute URL?
  18. Stefan Neufeind commented on patch set 4 12/11/17, 08:27

    @Benni: Improve this further? Or have it as a first step? I mean, regarding your (correct) question about absolute-urls for redirectUrl.

    TypoScriptFrontendController.php:2919

    another check for TYPO3_SITE_URL+REQUEST_URI then?
  19. Christoph Lehmann commented on patch set 4 12/11/17, 21:54

    TypoScriptFrontendController.php:2919 Reply

    is an absolute url possible with the given typolink configuration?
  20. Steffen Frese voted on patch set 4 CR +1 01/16/18, 13:36

  21. Reiner Teubner voted on patch set 4 CR +1 01/23/18, 09:16

  22. Mathias Schreiber voted on patch set 4 V +1 CR +1 02/07/18, 16:59

  23. Benni Mack voted on patch set 4 V +2 02/07/18, 18:49

  24. Benni Mack merged patch set 5 02/07/18, 18:49

  25. Benni Mack commented on patch set 5 02/07/18, 18:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit afd554bd265cdbfcaf98eb3bdbeb3f4f7ecd8415