Review main Merged

53988[TASK] EXT:form - allow validation translation for a field in all forms

David Gurk CR +2 V +2 Easy +6 −1 updated 09/20/17, 09:55

Commit message

This allows to translate a form element validation messages without
a specific form definition identifier.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Sascha Rademacher +1
    • Sonja Großewinkelmann +1
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • Jörg Bösche +1
    • Mathias Brodala +1
  • Verified V +2
    • Susi Moog +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2128

Show 23 earlier messages
  1. David Gurk uploaded patch set 1 09/08/17, 08:44

  2. TYPO3com voted on patch set 1 V -1 09/08/17, 09:05 Completed build in 20m 54s on Fri, 8 Sep, 11:05 AM Test Summary: 1 of 58506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14406

  3. Mathias Brodala updated the commit message in patch set 2 09/08/17, 09:24

  1. David Gurk updated the commit message in patch set 3 09/08/17, 09:45

  2. Mathias Brodala updated the commit message in patch set 4 09/08/17, 09:48

  3. Mathias Brodala commented on patch set 4 CR +1 09/08/17, 09:49

    Whatever you did, I had to revert the commit message to the previous version which was perfectly fine. ;-)
  4. TYPO3com voted on patch set 2 V -1 09/08/17, 09:51 Completed build in 26m 35s on Fri, 8 Sep, 11:51 AM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14414

  5. David Gurk updated the commit message in patch set 5 09/08/17, 10:03

  6. David Gurk commented on patch set 5 09/08/17, 10:04

    Now only the commit description updated.
  7. TYPO3com voted on patch set 4 V -1 09/08/17, 10:07 Completed build in 19m 03s on Fri, 8 Sep, 12:07 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14422

  8. TYPO3com voted on patch set 3 V -1 09/08/17, 10:12 Completed build in 27m 01s on Fri, 8 Sep, 12:12 PM Test Summary: 1 of 58506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14420

  9. David Gurk uploaded patch set 6 09/08/17, 10:37

  10. David Gurk commented on patch set 6 09/08/17, 10:37

    Change is now a TASK, no FEATURE
  11. Mathias Brodala commented on patch set 7 09/08/17, 10:53

    Published edit on patch set 6.
  12. TYPO3com voted on patch set 5 V -1 09/08/17, 11:03 Completed build in 1h 00m 01s on Fri, 8 Sep, 01:03 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14430

  13. Mathias Brodala voted on patch set 7 CR +1 09/08/17, 11:07

  14. TYPO3com voted on patch set 6 V +1 09/08/17, 11:35 Completed build in 58m 02s on Fri, 8 Sep, 01:35 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14440

  15. TYPO3com voted on patch set 7 V +1 09/08/17, 11:43 Completed build in 49m 53s on Fri, 8 Sep, 01:43 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14445

  16. Daniel Gohlke voted on patch set 7 CR +1 09/08/17, 13:53

  17. Ralf Zimmermann voted on patch set 7 CR +1 09/10/17, 14:01

  18. Sonja Großewinkelmann voted on patch set 7 CR +1 09/11/17, 08:23

  19. Ralf Zimmermann voted on patch set 7 V +1 09/11/17, 12:35

  20. Björn Jacob voted on patch set 7 CR +1 V +1 09/14/17, 10:31

  21. Sascha Rademacher voted on patch set 7 CR +1 09/18/17, 07:09

  22. Jörg Bösche voted on patch set 7 CR +1 09/18/17, 07:35

  23. Susi Moog voted on patch set 7 CR +2 V +2 09/20/17, 09:55

  24. Gerrit merged patch set 7 09/20/17, 09:55

  25. Susi Moog commented on patch set 8 09/20/17, 09:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6f4af4023dba4cf63b78a2cf8a790198e9d44589