Review main Merged

53993[BUGFIX] Fix using contains in query on property of group

Łukasz Uznański CR +2 V +2 Normal +48 −4 updated 09/09/17, 11:36

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Joerg Kummer +1
  • Verified V +2
    • Christian Kuhn +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1421

  1. Łukasz Uznański uploaded patch set 1 09/08/17, 09:30

  2. TYPO3com voted on patch set 1 V +1 09/08/17, 10:01 Completed build in 30m 23s on Fri, 8 Sep, 12:01 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14417

  3. Wouter Wolters commented on patch set 1 CR -1 09/08/17, 10:17

    please set the 3rd parameter of in_array to true
  4. Łukasz Uznański commented on patch set 2 09/08/17, 10:22

    Published edit on patch set 1.
  5. Wouter Wolters voted on patch set 2 CR +1 09/08/17, 10:24

  6. Tymoteusz Motylewski commented on patch set 2 09/08/17, 10:32

    it should be probably easy to add new test cases in typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php
  7. TYPO3com voted on patch set 2 V +1 09/08/17, 11:20 Completed build in 57m 54s on Fri, 8 Sep, 01:20 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14435

  8. Łukasz Uznański uploaded patch set 3 09/08/17, 15:51

  9. TYPO3com voted on patch set 3 V -1 09/08/17, 15:52 Completed build in 01m 44s on Fri, 8 Sep, 05:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14553

  10. Łukasz Uznański uploaded patch set 4 09/08/17, 15:54

  11. Łukasz Uznański uploaded patch set 5 09/08/17, 16:05

  12. TYPO3com voted on patch set 4 V +1 09/08/17, 16:18 Completed build in 23m 45s on Fri, 8 Sep, 06:18 PM Test Summary: 56839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14555

  13. TYPO3com voted on patch set 5 V +1 09/08/17, 16:25 Completed build in 20m 15s on Fri, 8 Sep, 06:25 PM Test Summary: 56839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14558

  14. Simon Praetorius uploaded patch set 6 09/09/17, 08:57

  15. TYPO3com voted on patch set 6 V -1 09/09/17, 09:08 Completed build in 10m 56s on Sat, 9 Sep, 11:08 AM Test Summary: 1 of 57170 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14618

  16. Łukasz Uznański uploaded patch set 7 09/09/17, 09:13

  17. TYPO3com voted on patch set 7 V +1 09/09/17, 09:29 Completed build in 16m 05s on Sat, 9 Sep, 11:29 AM Test Summary: 56829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14622

  18. Joerg Kummer voted on patch set 7 CR +1 V +1 09/09/17, 11:28

  19. Christian Kuhn voted on patch set 7 CR +2 V +2 09/09/17, 11:36

  20. Gerrit merged patch set 7 09/09/17, 11:36

  21. Christian Kuhn commented on patch set 8 09/09/17, 11:36

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 566801c88edfee307560134bc499aec0d8685743