Review main Merged

54004Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

Christian Kuhn CR +2 V +2 Easy +0 −28 updated 09/08/17, 11:25

Commit message

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Brodala +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Brodala +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 09/08/17, 10:14

  2. Christian Kuhn voted on patch set 1 CR -1 09/08/17, 10:17

  3. Christian Kuhn uploaded patch set 2 09/08/17, 10:18

  4. Helmut Hummel voted on patch set 2 CR +1 V +1 09/08/17, 10:21

  5. Mathias Brodala commented on patch set 2 CR +1 V +1 09/08/17, 10:31

    Agreed that this does not make sense for PHP >= 7.x since our errorhandler already handles Error with a backtrace.
  6. TYPO3com voted on patch set 1 V -1 09/08/17, 11:09 Completed build in 55m 00s on Fri, 8 Sep, 01:09 PM Test Summary: 1 of 58494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14431

  7. TYPO3com voted on patch set 2 V +1 09/08/17, 11:16 Completed build in 57m 55s on Fri, 8 Sep, 01:16 PM Test Summary: 58131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14433

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 09/08/17, 11:20

  9. Gerrit merged patch set 2 09/08/17, 11:20

  10. Christian Kuhn commented on patch set 3 09/08/17, 11:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 37948d8d6cd9346998de344fe66a9f4cd89b1ea1
  11. Helmut Hummel commented on patch set 3 09/08/17, 11:25

    thanks!