54004Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Brodala +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Brodala +1
- Helmut Hummel +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 911
-
Christian Kuhn uploaded patch set 1 09/08/17, 10:14
-
Christian Kuhn voted on patch set 1 CR -1 09/08/17, 10:17
-
Christian Kuhn uploaded patch set 2 09/08/17, 10:18
-
Helmut Hummel voted on patch set 2 CR +1 V +1 09/08/17, 10:21
-
Mathias Brodala commented on patch set 2 CR +1 V +1 09/08/17, 10:31
Agreed that this does not make sense for PHP >= 7.x since our errorhandler already handles Error with a backtrace. -
TYPO3com voted on patch set 1 V -1 09/08/17, 11:09 Completed build in 55m 00s on Fri, 8 Sep, 01:09 PM Test Summary: 1 of 58494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14431
-
TYPO3com voted on patch set 2 V +1 09/08/17, 11:16 Completed build in 57m 55s on Fri, 8 Sep, 01:16 PM Test Summary: 58131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14433
-
Christian Kuhn voted on patch set 2 CR +2 V +2 09/08/17, 11:20
-
Gerrit merged patch set 2 09/08/17, 11:20
-
Christian Kuhn commented on patch set 3 09/08/17, 11:20
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 37948d8d6cd9346998de344fe66a9f4cd89b1ea1 -
Helmut Hummel commented on patch set 3 09/08/17, 11:25
thanks!