Review main Merged

54007[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

Oliver Hader CR +2 V +2 Normal +58 −23 updated 11/11/17, 15:58

Commit message

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Gohlke +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Gohlke +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2431

Show 46 earlier messages
  1. Oliver Hader uploaded patch set 1 09/08/17, 10:51

  2. Oliver Hader commented on patch set 1 CR -1 09/08/17, 11:10

    labels containing a quote (") now needs to be handled... ;-)
  3. TYPO3com voted on patch set 1 V +1 09/08/17, 11:41 Completed build in 50m 34s on Fri, 8 Sep, 01:41 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14443

  4. Oliver Hader uploaded patch set 2 09/08/17, 12:33

  5. TYPO3com voted on patch set 2 V -1 09/08/17, 12:49 Completed build in 16m 07s on Fri, 8 Sep, 02:49 PM Test Summary: 73 of 57180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14470

  6. Oliver Hader uploaded patch set 3 09/08/17, 13:54

  1. TYPO3com voted on patch set 3 V +1 09/08/17, 14:08 Completed build in 13m 48s on Fri, 8 Sep, 04:08 PM Test Summary: 56821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14509

  2. Mathias Brodala commented on patch set 3 09/08/17, 14:48

    TranslationService.php:287

    This should be renamed to "propertyParts" I guess.
  3. Stefan Neufeind commented on patch set 4 09/09/17, 11:24

    Published edit on patch set 3.
  4. Stefan Neufeind commented on patch set 4 09/09/17, 11:25

    @Mathias: renamed property in the exception
  5. TYPO3com voted on patch set 4 V +1 09/09/17, 11:48 Completed build in 23m 41s on Sat, 9 Sep, 01:48 PM Test Summary: 58122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14643

  6. Jörg Bösche voted on patch set 4 CR +1 09/18/17, 08:00

  7. Sonja Großewinkelmann voted on patch set 4 CR +1 09/25/17, 08:27

  8. Georg Ringer commented on patch set 4 09/25/17, 19:37

    TranslationService.php:283

    which is a breaking change?!
  9. Stefan Neufeind commented on patch set 4 09/26/17, 07:06

    TranslationService.php:283 Reply

    I had the same feeling. But the function is marked @internal.
  10. Oliver Hader commented on patch set 4 10/19/17, 20:56

    TranslationService.php:283 Reply

    Yepp, that's why I changed it since it is internal
  11. Susi Moog voted on patch set 4 CR +1 10/19/17, 20:58

  12. Riccardo De Contardi commented on patch set 4 10/19/17, 21:29

    Works for multi checkbox but does not fix radio buttons, AFAICS. Or that does require a different issue and review?
  13. Stefan Neufeind uploaded patch set 5 10/25/17, 21:32

  14. Stefan Neufeind commented on patch set 5 CR +1 V +1 10/25/17, 21:33

    radio-buttons work the same way, just a small extension. imho we should have that in the same patch
  15. TYPO3com voted on patch set 5 V -1 10/25/17, 21:42 Completed build in 09m 01s on Wed, 25 Oct, 11:42 PM Test Summary: 2 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15872

  16. Riccardo De Contardi commented on patch set 5 V +1 10/25/17, 22:17

    verified with both checkboxes and radio buttons; verified with period,comma, semicolon,single quote, double quote, backtick, slash, backslash, ampersand
  17. TYPO3com voted on patch set 5 V +1 10/26/17, 08:34 Completed build in 11h 10m 49s on Thu, 26 Oct, 10:34 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15872

  18. Daniel Gohlke voted on patch set 5 CR +1 V +1 11/10/17, 09:34

  19. Markus Klein commented on patch set 5 11/10/17, 10:03

    this is a bug report message and not a commit message it should describe what is changed an not was is broken
  20. Mathias Brodala updated the commit message in patch set 6 11/10/17, 10:23

  21. Daniel Gohlke voted on patch set 6 CR +1 V +1 11/10/17, 10:31

  22. TYPO3com voted on patch set 6 V +1 11/10/17, 10:33 Completed build in 09m 53s on Fri, 10 Nov, 11:33 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16230

  23. Stefan Neufeind voted on patch set 6 CR +2 V +2 11/11/17, 15:57

  24. Gerrit merged patch set 6 11/11/17, 15:57

  25. Stefan Neufeind commented on patch set 7 11/11/17, 15:58

    straight cherry-pick to 8.7 not possible automatically. will do that later this evening, or somebody else jumps in.