Review TYPO3_8-7 Merged

54010Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

Christian Kuhn CR +2 V +2 Easy +0 −28 updated 09/08/17, 12:10

Commit message

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn commented on patch set 1 09/08/17, 11:20

    Cherry Picked from branch master.
  2. Helmut Hummel voted on patch set 1 CR +1 V +1 09/08/17, 11:25

  3. TYPO3com voted on patch set 1 V +1 09/08/17, 12:05 Completed build in 44m 28s on Fri, 8 Sep, 02:05 PM Test Summary: 59026 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-854

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 09/08/17, 12:10

  5. Gerrit merged patch set 1 09/08/17, 12:10