Review TYPO3_8-7 Merged

54045[TASK] Use TYPO3_OS constant in Services registration

Christian Kuhn CR +2 V +2 Easy +2 −3 updated 09/08/17, 22:33

Commit message

There is a comment that TYPO3_OS is not yet defined, which
is wrong as it is one of the first things available during bootstrap,
so the check can be used directly.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn commented on patch set 1 09/08/17, 21:38

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/08/17, 21:53 Completed build in 15m 33s on Fri, 8 Sep, 11:53 PM Test Summary: 1 of 59396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-877

  3. TYPO3com voted on patch set 1 V +1 09/08/17, 22:02 Completed build in 39m 59s on Sat, 9 Sep, 12:02 AM Test Summary: 59032 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-877

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 09/08/17, 22:33

  5. Gerrit merged patch set 1 09/08/17, 22:33