54049[BUGFIX] Use correct values in settings InstallTool
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php1+12 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml1+2 −0
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php+15 −3
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Settings/LocalConfiguration/SubSection.html+8 −0
Review log 1013
-
Simon Praetorius uploaded patch set 1 09/09/17, 08:57
-
TYPO3com voted on patch set 1 V +1 09/09/17, 09:14 Completed build in 17m 30s on Sat, 9 Sep, 11:14 AM Test Summary: 56811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14619
-
Simon Praetorius uploaded patch set 2 09/09/17, 13:59
-
TYPO3com voted on patch set 2 V +1 09/09/17, 14:21 Completed build in 22m 12s on Sat, 9 Sep, 04:21 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14679
-
Oliver Klee commented on patch set 2 09/09/17, 14:36
-
Benni Mack commented on patch set 2 09/09/17, 14:44
DefaultConfigurationDescription.yaml:402no no no, please - no option calling "disable=true" - go with "compareValuesWithCurrentConfiguration=false" please -
Simon Praetorius uploaded patch set 3 09/09/17, 15:50
-
Benni Mack voted on patch set 3 CR +1 09/09/17, 15:58
-
Benni Mack voted on patch set 3 V +1 09/09/17, 16:04
-
TYPO3com voted on patch set 3 V +1 09/09/17, 16:11 Completed build in 21m 04s on Sat, 9 Sep, 06:11 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14689
-
Stefan Neufeind voted on patch set 3 CR +1 09/09/17, 16:45
-
Christian Kuhn voted on patch set 3 CR +2 V +2 09/09/17, 16:54
-
Gerrit merged patch set 3 09/09/17, 16:54
ConfigurationManager.php:143