Review main Merged

54051[TASK] Update localization rendering tests to newest Testing Framework

Tymoteusz Motylewski CR +2 V +2 Easy +0 −49 updated 09/09/17, 11:22

Commit message

addTypoScriptToTemplateRecord method was added to FunctionalTestCase.php
in Testing Framework.
So we can remove it from test cases.
Fix two other germlins also (unneeded comment and unused variable).

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Tymoteusz Motylewski uploaded patch set 1 09/09/17, 10:20

  2. TYPO3com voted on patch set 1 V +1 09/09/17, 10:35 Completed build in 15m 29s on Sat, 9 Sep, 12:35 PM Test Summary: 58122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14633

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 09/09/17, 11:11

  4. Stefan Neufeind voted on patch set 1 CR +1 V +1 09/09/17, 11:13

  5. Tymoteusz Motylewski voted on patch set 1 CR +2 V +2 09/09/17, 11:20

  6. Gerrit merged patch set 1 09/09/17, 11:20

  7. Tymoteusz Motylewski commented on patch set 2 09/09/17, 11:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e3510f88408b9b59d7517e1d3053d1ff99c8296e