Review TYPO3_8-7 Merged

54058[BUGFIX] Make Extbase pagination work with QueryBuilder queries

Christian Kuhn CR +2 V +2 Easy +23 −3 updated 09/09/17, 13:11

Commit message

Now you can pass a query built by QueryBuilder to $query->statement(),
and use the QueryResult for pagination.

So inside repository you can create custom query like:

$queryBuilder->select('*')->...
$query = $this->createQuery();
$query->statement($queryBuilder);
return $query->execute();

and pass the result to paginate ViewHelper.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn commented on patch set 1 09/09/17, 11:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/09/17, 12:18 Completed build in 31m 47s on Sat, 9 Sep, 02:18 PM Test Summary: 59020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-886

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 09/09/17, 13:11

  4. Gerrit merged patch set 1 09/09/17, 13:11